| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[buaa]【Infer Symbolic Shape BUAA No.184】Add conv3d_transpose & conv2d_transpose & conv2d_transpose_bias op #67635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
luotao1
added
contributor
|
Sorry to inform you that 666e403's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
crazyxiaoxi
changed the title
|
conv2d_transpose_bias对应单测：test/mkldnn/test_conv2d_transpose_mkldnn_op.py test_conv3d_transpose_op coverage 流水线未执行，test_conv2d_transpose_op会产生新符号手动关闭，test_conv2d_transpose_mkldnn_op 未开启check_pir flag。 |
paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/binary_infer_sym.h
Outdated
Show resolved
Hide resolved
paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/binary_infer_sym.cc
Outdated
Show resolved
Hide resolved
conv3d_transpose还有单测： /test/legacy_test/test_conv3d_transpose_part2_op.py |
这个coverage 流水线应该也未执行 |
本地测试
|
| self.check_output_with_place(place, atol=1e-5) | ||
| self.check_output_with_place(place, atol=1e-5, check_pir=True) | ||
| else: | ||
| self.check_output() | ||
| self.check_output(check_pir=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里先不要打开，明天本地再测试下
|
Sorry to inform you that e0222df's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
crazyxiaoxi
force-pushed
the
cinn/conv3d
branch
from
2ecfb1c to
954ec66
Compare
新增的单测也已经通过
|
| "The Attr(output_padding) and Attr(stride) of Op(conv_transpose) " | ||
| "should be the same.")); | ||
|
|
||
| const bool channel_last = (data_format != "NHWC"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
channel_last就是NHWC吧
| const bool channel_last = (data_format != "NHWC"); | ||
| const symbol::DimExpr C = | ||
| (channel_last ? x_shape[1] : x_shape[x_shape.size() - 1]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
修改一下 channnel_last 变量命名
| bool Conv3dOpInferSymbolicShape(pir::Operation *op, | ||
| pir::InferSymbolicShapeContext *infer_context) { | ||
| return Conv2dOpInferSymbolicShape(op, infer_context); | ||
| } | ||
|
|
||
| bool convtransposefunction(pir::Operation *op, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
函数命名用单词首字母大写的形式
crazyxiaoxi
force-pushed
the
cinn/conv3d
branch
from
1fd1ef6 to
b455a17
Compare
fix comment fix comment fix comment
crazyxiaoxi
force-pushed
the
cinn/conv3d
branch
from
b455a17 to
97e2c12
Compare
PR Category
CINN
PR Types
improvements
Description
添加 conv3d_transpose & conv2d_transpose & conv2d_transpose_bias算子符号推导接口
全部都有对应单测，Optest且check打开，本地已经测试通过
Pcard-67164