| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 02:27:05 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=350.457415,conversation_content-fragment;desc="conversation_content fragment";dur=1186.513121,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=328.478122,nginx;desc="NGINX";dur=1.215869,glb;desc="GLB";dur=101.806924
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=M13GaSD0Ymb2bgnckWcA%2FHZXjxt3egVGdFlTkEHdRV7oQR0fCMgRHb1HTK961y2zEs%2F%2FZ19M37pCjy53aMD0HnPQ2pBYFhRIosVEtBko57lrJacPDKVb9L7IgiWARGP%2FkzLAtjkpCdiY7RJu5Fiz6KOUB70R5YsjA%2F2C20tLhlXR7frc5upStrrtUjvZDmc%2Fyu30k1bwjjMVHjmjIcQ6x0SSFWNTA%2FKN8Tct7DHGhsGLSZafChHM3IOzaWM8%2FxhQeMetR0zlcJA3HY7V%2BjZyoQ%3D%3D--eSSes4AycB2MPUYG--u5kt4TC%2B8R9du17mv2OREg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.970428308.1753496824; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 02:27:04 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 02:27:04 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8DFE:29FD1F:C2CA1:133B85:68843CF8
[SOT] Catch `BreakGraphError` when extend `ListVariable` with `RangeVariable` by gouzil · Pull Request #67591 · PaddlePaddle/Paddle · GitHub
[SOT] Catch
[SOT] Catch
SigureMo
changed the title
[SOT] Fallback
[SOT] Catch Aug 28, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT] Catch BreakGraphError when extend ListVariable with RangeVariable
#67591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 14 commits into
PaddlePaddle:develop
from
gouzil:sot/fix_list_unpack_range
Aug 29, 2024
Merged
[SOT] Catch BreakGraphError when extend ListVariable with RangeVariable
#67591
SigureMo
merged 14 commits into
PaddlePaddle:develop
from
gouzil:sot/fix_list_unpack_range
Aug 29, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Aug 28, 2024
| @@ -1056,7 +1056,8 @@ def build_seq_unpack(self, instr: Instruction): | |||
|
|
|||
| retval = [] | |||
| for item in unpack_values: | |||
| assert isinstance(item, (TupleVariable, ListVariable)) | |||
| if isinstance(item, (TupleVariable, ListVariable)): | |||
| BreakGraphError(f"{type(item)} not support unpack") | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你确定不是 not isinstance 才 BreakGraph？
而且 BreakGraph 的 raise 呢？
| @@ -1561,6 +1563,7 @@ def MAP_ADD(self, instr: Instruction): | |||
| self.stack.peek[instr.arg], key, value | |||
| ) | |||
|
|
|||
| @call_break_graph_decorator(push_n=1) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
确定会 push 一个元素么？我看咋好像没有 push
| @@ -1077,6 +1078,7 @@ def BUILD_TUPLE_UNPACK_WITH_CALL(self, instr: Instruction): | |||
| def BUILD_TUPLE_UNPACK(self, instr: Instruction): | |||
| self.build_seq_unpack(instr) | |||
|
|
|||
| @call_break_graph_decorator(push_n=1) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果这里加，那么所有用了 self.build_seq_unpack(instr) 的都应该加
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
本 PR 先不修改这里，会引发打断
下个 PR 优化打断后再修改
SigureMo
changed the title
ListVariable unpack RangeVariableBreakGraphError when extend ListVariable with RangeVariable
…unpack_range # Conflicts: # test/sot/test_04_list.py
SigureMo
reviewed
Aug 28, 2024
Co-authored-by: Nyakku Shigure <sigure.qaq@gmail.com>
21 tasks
SigureMo
reviewed
Aug 28, 2024
| @@ -1071,12 +1072,15 @@ def build_seq_unpack(self, instr: Instruction): | |||
| ) | |||
| ) | |||
|
|
|||
| @call_break_graph_decorator(push_n=0) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个 push 是 0 吗？不是往栈上 push 了一个吗？
SigureMo
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Performance
Description
修复
b2124e7(#67344) 遇到的问题在下一阶段支持
list.extend(list, range | list | dict)