| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 21:05:58 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=309.126888,conversation_content-fragment;desc="conversation_content fragment";dur=759.864093,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=428.25018,nginx;desc="NGINX";dur=1.210328,glb;desc="GLB";dur=101.569261
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=N8z%2BfGa1l9SdLWVeccqd7DPCBC1FDHNATssQCQYdPZYTs5duDVRB1isp3RwzHkkl05NW2oBioCzmEvkYM6R%2F%2BQ7neBUuVC5pfVtEV9%2BDFclqLLR9dvc4PU7fCUwBwd7n9fNZxUxlQ8sBwFPMbK8NNJPsK4kg4we%2FVCjC1a57Zgo7LEP3k%2Fop3Uv39nti6agh5A2V5jIbDcUURMcxmuTI2t%2BYeV%2FE7h1oE%2FOWFaYZBdAF%2BmXsMuPMvqUoXRA2NH9ySIHtgZtB8wlVX%2Fd7fpxK%2BQ%3D%3D--UBREsWxif82ZsWvO--qqfYhKcCMBrUvsAQdUTx0g%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1141303204.1753304758; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:05:58 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:05:58 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E30A:12F48D:10E2EEE:1417DE1:68814EB6
[Operator]Delete XShape for squeeze output by Aurelius84 · Pull Request #67355 · PaddlePaddle/Paddle · GitHub
Aurelius84
dismissed stale reviews from zyfncg, zhangbo9674, and winter-wang
via
August 14, 2024 02:21
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[Operator]Delete XShape for squeeze output #67355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
winter-wang
previously approved these changes
Aug 13, 2024
zhangbo9674
previously approved these changes
Aug 13, 2024
zyfncg
previously approved these changes
Aug 13, 2024
Aurelius84
dismissed stale reviews from zyfncg, zhangbo9674, and winter-wang
via
0f25bf0
XiaoguangHu01
previously approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chen2016013
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
winter-wang
approved these changes
Aug 14, 2024
Hongqing-work
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for InferSymbolicShapeInterface
gongshaotian
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for ops.yaml & SqueezeOpInferSymbolicShape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Operator Mechanism
PR Types
Deprecations
Description
Pcard-67164
What's New?
退场了动态图和新IR下 squeeze 算子中的XShape字段，实现动静统一，具体改动：
1. 在legacy里隔离旧静态图的定义
动态图和新IR的算子体系使用了 phi/ops.yaml，实现理想态的动静统一。为了保证旧IR下的算子表示层面的兼容，因此在legacy目录下static_ops.yaml和static_backward.yaml单独定义了squeeeze的前反向算子，Kernel使用 squeeze_with_xshape，并在Kernel定义中标记FIXME
2. 需要对squeeze2_grad的转换规则做添加
test_seq2seq 和 test_bmn 两个单测依赖squeeze2_grad的转换规则，并在单测体系下单独添加了test_squeeze_grad_translator.py 单测
3. 修改了pd_to_cinn pass 逻辑
移除了 pd_to_cinn_pass 中 SqueezeOpPattern 中的 ReplaceWithCinnReshape 逻辑，无需再处理XShape
4. 部分融合Pass需要移除XShape的DRR定义
目前框架里主要涉及squeeze_transpose_onednn_fuse_pass和fused_rotary_position_embedding_pass两个Pass