| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 21:04:38 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=304.718159,conversation_content-fragment;desc="conversation_content fragment";dur=982.45714,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=319.41455,nginx;desc="NGINX";dur=1.306963,glb;desc="GLB";dur=101.565938
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=v%2FZS63KANgzOjFRBfFSJF1u0O6gzbhAxx99wnbvD0KIAmMDeQ1gJ%2FFQwL%2BxJDWd2vjz6mkJ8CuRE1SDzXaEHck9rKeCIYnx3w%2FiNIr7vgvmsNfn%2FrRybcpLn%2FSgbYDD5giadLJs%2B5DOI2Hy7y1NrjyIPXpst9n0zj3o%2F5LocX5GvP5OwQWYfXwnBOy8QKetdb9%2F1JpRegSHoN26KCQ6fGBEO9uuC6P%2FZ3GGOvyQKXX4SGwkTluTYaqH3uzs0DyxcyasnkxQY257RSDxxZj9NgA%3D%3D--DpP2K7iT3K6KmDkW--LcySv37v5W2dDJqkArx7OA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.182280103.1753304677; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:04:37 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:04:37 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 80E0:25703E:FD06E:14D3B4:68814E65
[Auto Parallel] Support obtain op's struct_name for PIR by AndSonder · Pull Request #67174 · PaddlePaddle/Paddle · GitHub
AndSonder
requested review from
XiaoguangHu01,
zhiqiu,
Xreki,
qili93 and
Aurelius84
as code owners
August 7, 2024 15:02
AndSonder
changed the title
[Auto Parallel] Support struct_name for PIR
[Auto Parallel] Support obtain op's struct_name for PIR
Aug 7, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[Auto Parallel] Support obtain op's struct_name for PIR #67174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JZ-LIANG
merged 1 commit into
PaddlePaddle:develop
from
AndSonder:fit_struct_name_for_pir
Aug 9, 2024
Merged
[Auto Parallel] Support obtain op's struct_name for PIR #67174
JZ-LIANG
merged 1 commit into
PaddlePaddle:develop
from
AndSonder:fit_struct_name_for_pir
Aug 9, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndSonder
requested review from
XiaoguangHu01,
zhiqiu,
Xreki,
qili93 and
Aurelius84
as code owners
|
你的PR提交成功，感谢你对开源项目的贡献! |
AndSonder
changed the title
JZ-LIANG
reviewed
Aug 8, 2024
| all_ops = ( | ||
| paddle.static.default_main_program().global_block().ops | ||
| ) | ||
| op_num = len(all_ops) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
目前方案比较 hack，通过记录 idx + 遍历方式corner case会有 bug，建议未来最终还是做到 op build 的过程中。
可以参考 paddle/fluid/pir/dialect/operator/ir/api_builder.h
但需要在 C++ 端感知 python 端的全局变量，可以后续再完善
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯嗯 可以后续再进行完善，写这一版方案的时候其实也主要是因为对 c++ 端感知 python 全局变量没有思路，可以先用这一版 hack 的支持 vpp 实现
| ) | ||
| op_num = len(all_ops) | ||
|
|
||
| for idx in reversed(range(op_num_before, op_num)): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
考虑在 build 处设置 struct_name 还有一个有点： 后续你要想如何个 fw op 对应的 bw op 添加 对应的struct_name。
bw op 只能在 build 处添加，否则需要额外维护一个 fw op 到 bw op 的映射关系(这个方式也比较 hack)，到时可以思考一下如何统一。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
考虑在 build 处设置 struct_name 还有一个有点： 后续你要想如何个 fw op 对应的 bw op 添加 对应的struct_name。 bw op 只能在 build 处添加，否则需要额外维护一个 fw op 到 bw op 的映射关系(这个方式也比较 hack)，到时可以思考一下如何统一。
好的，目前这里也不影响 vpp 里面用 struct_name，vpp 里面只用补全前向算子的 chunk_id 就可以了，backward 根据前向算子的信息补全反向算子的 chunk_id
JZ-LIANG
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Auto Parallel
PR Types
Not User Facing
Description
Pcard-76459
将 struct_name 作为 op 的 attr 为后续 vpp 切图服务
主要思路：修改 name_struct guard, 让其在 pir mode 下补全 op 的 struct_name