| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 23:46:08 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=307.750481,conversation_content-fragment;desc="conversation_content fragment";dur=906.224608,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=365.88324,nginx;desc="NGINX";dur=0.682929,glb;desc="GLB";dur=100.635022
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=fWTFcyIrnFkhigH8Mm9EYSe2kK5rt20vwDVYq3EtmZ0RzqFZqK3JE%2B0PLVt8NUYjxUX6ptxJ422NEFnsRCn%2BZjn1aWDXIKgUppKHb9SMyNlhzNiiiWrE7U3Nw95HIb3zUXLYDbIJotG1eFM2udA2yqiFdvhA0TD%2BfbvZzV6OfvLcxJ%2B7YgvYAXgo2WV%2F9YO046ErZ9AVvrnUD2pXdE7%2FRob0hzLR9bEXvRPI%2F%2FWEpFw%2BjK9VXtWg6879Qomb4Kbn%2BRI23pkJg1O1FWwYRXBuww%3D%3D--1EvG9Sa50rYCPz%2Bt--wUwcj4KbKYJQoEe5rakG7Q%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.291443491.1753400767; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 23:46:07 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 23:46:07 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E7D2:1EB2CB:1DDA6:2EC37:6882C5BF
[Opearator]Delete XShape from flatten output by Aurelius84 · Pull Request #67172 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[Opearator]Delete XShape from flatten output #67172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
commented
Aug 13, 2024
| @@ -286,6 +286,18 @@ | |||
| func: fetch_barrier | |||
| optional: x | |||
|
|
|||
| - op : flatten | |||
| args : (Tensor x, int start_axis, int stop_axis) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| args : (Tensor x, int start_axis, int stop_axis) | |
| args : (Tensor x, int start_axis = 1, int stop_axis = 1) |
在原生ops.yaml里有默认值，这里是否应该对齐？下个PR会单独对齐
zhangbo9674
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zyfncg
approved these changes
Aug 13, 2024
gongshaotian
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for yaml
XiaoguangHu01
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jeff114514
pushed a commit
to Jeff114514/Paddle
that referenced
this pull request
Aug 14, 2024
* [Opearator]Delete XShape from flatten output * fix flatten operator auto-generator OpMaker bug * remove usless ArgumentMapping * fix infersymbolicShape * fix x_grad->dims * add WithXShapeGradOpTranscriber * fix spmd rules * fix code style * fix xpu kernel select problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Operator Mechanism
PR Types
Deprecations
Description
Pcard-67164
What's New?
退场了动态图和新IR下Flatten算子中的XShape字段，实现动静统一，具体改动：
1. 旧静态图下为flatten_contiguous_range
目前flatten的前反向算子已经在ops/bacward.yaml中，即已为理想态。但旧的静态图下是flatten_contiguous_range，通过flatten(flatten_contiguous_range)这种别名的形式映射的。当把XShape退场之后，需要在static_ops/backward.yaml 新增flatten_contiguous_range前反向算子的yaml定义。
2. 旧静态图下需添加exclude过滤名单
需要在legacy目录下对flatten的前反向算子添加旧静态图算子的过滤机制，以flatten_contiguous_range为名单过滤是无效的。
3. 修改flatten spmd 中对reshapeinferspmd的调用
需要将ReshapeInferSpmdDynamic替换为ReshapeInferSpmd，因为前者是面向XShape的切分推导规则，相关的单测清理XShape相关的Assert逻辑。
4. 隔离旧静态图下的yaml定义
由于动静统一的flatten使用的是ops/backward.yaml，为了确保不影响旧静态图算子定义，需要在static_ops.yaml中单独定义带XShape的旧 flatten 算子定义。
5. 添加了GradWithXGradOpTranscriper
类似Reshape/Flatten/Squeeze/Unsqueeze 算子反向之前依赖的是XShape，现在是X，因此需要添加转换逻辑。
为什么不需要写前向算子的转换逻辑？
答：因为在ProgramTranslator中，是以yaml定义中的output字段为基准，转换得到output_types，自然而然不会包含xshape（如下图）
6. 修改transpose_flatten_concat_fuse_pass
需要修改Fuse中DRR Pattern 规则定义，移除xshape的匹配。
7. 修改XPU上的flatten_grad的注册管理
从日志来看，在XPU硬件上flatten_grad没有找到fp16支持的kernel，导致fallback到了CPU，但CPU上是不支持FP16的。问题点在于此处XPU上不应该找不到flatten_grad kernel，怀疑应该xpu_list 的dtype映射有关系。
