CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
【Infer Symbolic Shape BUAA No.10 No.73 No.78】Add mode , margin_cross_entropy , box_clip. op #66730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
test_index_select_strided.py 中已包含OpTest单测,self.check_output() 确认使用,申请approve流水线 |
paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/binary_infer_sym.cc
Show resolved
Hide resolved
fc57009
to
b1be1fc
Compare
b1be1fc
to
1fecfe5
Compare
|
||
for (size_t i = 0; i < logits_rank; i++) { | ||
if (i != axis) { | ||
infer_context->AddBroadcastableCstr(logits_dims[i], labels_dims[i]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里应该是 Equal 约束吧?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
|
||
if (labels_dims.size() > 1) { | ||
infer_context->AddEqualCstr(logits_dims[axis], one); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里逻辑和infer meta不太符合,和之前的相等约束一并修改后再合并吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
Merge branch 'cinn/mode' into cinn/margin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
if (labels_dims.size() > 1) { | ||
infer_context->AddEqualCstr(logits_dims[axis], one); | ||
infer_context->AddEqualCstr(labels_dims[axis - 1], one); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
infer meta里是检查labels_dims[logits_rank - 1]是否等于1,再确认下是否一致吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
那下一个PR顺带修复一下吧,提的时候把这个PR链接带上
…entropy , box_clip. op (PaddlePaddle#66730) * mode * boxclip * test_op * testop * margin_cross_entropy_op * resolve conflict * resolve conflict * resolve conflict * testop * testop * testop * tensor * fix fix conflict fix conflict fix conflict * fix * test * fix problem * fix equal * Update unused viriable * static check * rerun * add cstr * fix small problem * equal constrain * change change change * codestyle * fix error * comment fix * fix comment * fix
PR Category
CINN
PR Types
improvements
Description
添加mode , margin_cross_entropy,box_clip算子符号推导接口
均已检查Optest