| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 21:10:07 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=318.442565,conversation_content-fragment;desc="conversation_content fragment";dur=995.650358,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=355.507593,nginx;desc="NGINX";dur=0.80835,glb;desc="GLB";dur=103.595315
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=nHZrZOfs2xhG4ou4FNLj0mrpVAktd3yTMxZOdUBV4pv4DSPF%2FrwFr3UGTxBOiMmxTUiNktg%2BWvT2n1%2FNC%2BjOIIvKrY806H5JGfd8npZq2cdc5h7RpbhI%2BCQxqjHQ5F%2FaL5cGWAFlMFdq0xqLy%2Fh%2BdTFohfKJY%2FhRXRhPksYWbLV%2F6R1Yko35ZZWNlD%2FoUAQGoaTBRiThW4sIP8I4jWWyz9gqczJrOf6t0fyo9QE8qrUVvp15A4c04IkaaMgbDJCXOHNX0uBo2ZBpuYZ%2Fv%2Fknxg%3D%3D--ANwPHXZ085TQYvWU--EEploB6Xsaqq3sVeWPkRjA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1060188713.1753305005; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:10:05 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:10:05 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E44A:12BD61:10C8679:13FF71E:68814FAD
[Typing][C-121,C-122,C-123,C-124] Add type annotations for `python/paddle/quantization/{base_observer,factory,ptq,qat}.py` by enkilee · Pull Request #66693 · PaddlePaddle/Paddle · GitHub
[Typing][C-121,C-122,C-123,C-124] Add type annotations for
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[Typing][C-121,C-122,C-123,C-124] Add type annotations for python/paddle/quantization/{base_observer,factory,ptq,qat}.py
#66693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
megemini
reviewed
Jul 29, 2024
SigureMo
reviewed
Jul 30, 2024
| @@ -73,7 +80,7 @@ def _instance(self, layer: Layer) -> BaseQuanter: | |||
| ObserverFactory = QuanterFactory | |||
|
|
|||
|
|
|||
| def quanter(class_name): | |||
| def quanter(class_name: str) -> BaseQuanter: | |||
| r""" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2024-07-29 18:07:11 ----------------Check results--------------------
2024-07-29 18:07:11 paddle.quantization.quanter:1
2024-07-29 18:07:11 <string>:10:11: error: Name "CustomizedQuanter" is not defined [name-defined]
2024-07-29 18:07:11 <string>:11:35: error: Argument "activation" to "QuantConfig" has incompatible type "Callable[[str], BaseQuanter]"; expected "QuanterFactory" [arg-type]
2024-07-29 18:07:11 <string>:11:51: error: Argument "weight" to "QuantConfig" has incompatible type "Callable[[str], BaseQuanter]"; expected "QuanterFactory" [arg-type]
2024-07-29 18:07:11 Found 3 errors in 1 file (checked 1 source file)
2024-07-29 18:07:11
2024-07-29 18:07:11
2024-07-29 18:07:11 >>> Mistakes found in type checking!
2024-07-29 18:07:11 >>> Please recheck the type annotations. Run `tools/type_checking.py` to check the typing issues:
2024-07-29 18:07:11 > python tools/type_checking.py paddle.quantization.quanter
2024-07-29 18:07:11 ----------------End of the Check--------------------
这示例代码看样子本来就不能跑，直接在最前面加个 # type: ignore 吧，在 # doctest: +SKIP('need 2 file to run example') 下一行单独写一行
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
收到，我看其他都是加在 # doctest: +SKIP('xxxxxxx') 上面来着？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# type: ignore 和 # doctest: +SKIP('xxxxxxx') 互不影响，前者是应对 type checking ，后者是应对 example code running check ～ 注意一下，针对整段代码，都需要独占一行 ～
SigureMo
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow
Lans1ot
pushed a commit
to Lans1ot/Paddle
that referenced
this pull request
Aug 5, 2024
…ddle/quantization/{base_observer,factory,ptq,qat}.py` (PaddlePaddle#66693)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
User Experience
PR Types
Improvements
Description
C-121,C-122,C-123,C-124