| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 21:08:04 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=372.70482,conversation_content-fragment;desc="conversation_content fragment";dur=1460.994789,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=421.684475,nginx;desc="NGINX";dur=0.63956,glb;desc="GLB";dur=100.293466
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=xjntkDlUyFc%2FqXeClBbVDYc3EM%2Fs7pqaoBpJ24MW2De0wo4qa3e9HsOrws8PwGlWHPdFUSR1R8UBKSoJdIH00f7jifOmip%2Fl2%2BBbStevLCpaHTtXNWI%2BRaKCKhL5iofm6VnjS9T3t4j4vKl6%2BIg82yKe5rLTa%2FEV5UL7MlHmiBV1uLTieyT9At6eXRn2iDTpEsO6WBbgRH2y7hSVj3qWdQWOsmM45xAbdrUvfynW7PBO5ATeq509cEzJvKhk2jefO%2B9nndDd2rY91Vqu%2Bu1E%2Bw%3D%3D--ju3J0cTTa5T6vW5g--M7MNv8ViDZ6wOyc3JrhSuw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1567095102.1753304883; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:08:03 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:08:03 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A3F4:256CA9:10C39FA:13F9701:68814F33
[PIR] Refactor pir GetValueName - part 2 by gouzil · Pull Request #66559 · PaddlePaddle/Paddle · GitHub
SigureMo
changed the title
[WIP][PIR]refactor pir GetValueName - part 2
[WIP][PIR] Refactor pir GetValueName - part 2
Jul 27, 2024
SigureMo
changed the title
[WIP][PIR] Refactor pir GetValueName - part 2
[PIR] Refactor pir GetValueName - part 2
Jul 27, 2024
SigureMo
changed the title
[PIR] Refactor pir GetValueName - part 2
[Typing][PIR] Refactor pir GetValueName - part 2
Jul 27, 2024
SigureMo
changed the title
[Typing][PIR] Refactor pir GetValueName - part 2
[PIR] Refactor pir GetValueName - part 2
Jul 28, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[PIR] Refactor pir GetValueName - part 2 #66559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 16 commits into
PaddlePaddle:develop
from
gouzil:pir/reconfiguration_getname_2
Jul 28, 2024
Merged
[PIR] Refactor pir GetValueName - part 2 #66559
SigureMo
merged 16 commits into
PaddlePaddle:develop
from
gouzil:pir/reconfiguration_getname_2
Jul 28, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Jul 25, 2024
| @@ -2,3 +2,8 @@ cc_library( | |||
| pir_general_functions | |||
| SRCS general_functions.cc analysis_info.cc | |||
| DEPS op_dialect op_dialect_vjp pir) | |||
|
|
|||
| cc_library( | |||
| pir_analysis_name | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个不能放在 pir_general_functions 里么？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以，但是 pybind 不需要依赖pir_general_functions里的方法，就拆开了
SigureMo
reviewed
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name_analysis
…ration_getname_2 # Conflicts: # paddle/fluid/pybind/pir.cc
SigureMo
reviewed
Jul 27, 2024
| @@ -54,6 +53,7 @@ | |||
| #include "paddle/fluid/pir/transforms/gpu/fused_bn_add_act_pass.h" | |||
| #include "paddle/fluid/pir/transforms/passes.h" | |||
| #include "paddle/fluid/pir/utils/general_functions.h" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以，但是 pybind 不需要依赖
pir_general_functions里的方法，就拆开了
这不是依赖了么
paddle/fluid/pybind/pir.cc
Outdated
| @@ -548,7 +309,7 @@ void PruneWithInput(const std::vector<pir::Value> &input_vars, | |||
| auto input = input_vars[idx]; | |||
| auto origin_op = input.defining_op(); | |||
| std::string name = "input_" + std::to_string(idx); | |||
| if (auto names = name_analysis::TryGetValueFirstName(input)) { | |||
| if (auto names = pir::utils::name_analysis::TryGetValueFirstName(input)) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
要不 using pir::utils::name_analysis 一下？
| @@ -103,54 +104,16 @@ static auto GetNameFromValue(const ::pir::Block *block, | |||
| true, | |||
| phi::errors::InvalidArgument( | |||
| "GetNameFromValue should allow input or output at least one.")); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
参数 allow_input 和 allow_output 可以删掉了，block 也可以删掉了
SigureMo
changed the title
SigureMo
reviewed
Jul 27, 2024
SigureMo
changed the title
SigureMo
changed the title
SigureMo
approved these changes
Jul 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow
SigureMo
changed the title
lixcli
pushed a commit
to lixcli/Paddle
that referenced
this pull request
Aug 5, 2024
--------- Co-authored-by: SigureMo <sigure.qaq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Performance Optimization
PR Types
Not User Facing
Description
相关链接: