| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 00:44:09 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=350.720933,conversation_content-fragment;desc="conversation_content fragment";dur=1026.185687,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=365.680293,nginx;desc="NGINX";dur=0.760891,glb;desc="GLB";dur=101.167929
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=0B3ai%2B83Svui7SFrXGnRbnk2QC08Pgd8DvR7YU8zGlXl%2BfFKPZZ58ZvGviBMvw98zV%2B1QrXvd0gAVR15vdO0S1%2BKBIytq8AEgzERKwVA2LDBhb14FN9U%2FGvtap9DiSkj%2FICpkviO1DCxMdjkX90MC4HV2ywfY4XaN7%2FZycB5Uptt1b6D5Q2cv9zEKJQiiwkgaoYCUyH5LV0n9o9id%2B8Qrxrqm%2BKkq4iTNsE7LCPwSsuFn23%2F8v8gGFNetoULGeeqDthSmS%2B%2BurHXyO83kzMaQA%3D%3D--2gIyY2nrlhXb%2BMiH--qJ0whC1M7GK7CO%2BTRwSvvw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.579589293.1753490648; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 00:44:08 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 00:44:08 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D6A2:3ED739:62EB6:9F363:688424D8
[CINN]apply broadcast tree optimization by Hongqing-work · Pull Request #66537 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[CINN]apply broadcast tree optimization #66537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Hongqing-work
merged 4 commits into
PaddlePaddle:develop
from
Hongqing-work:broadcast-tree-s5
Jul 26, 2024
Merged
[CINN]apply broadcast tree optimization #66537
Hongqing-work
merged 4 commits into
PaddlePaddle:develop
from
Hongqing-work:broadcast-tree-s5
Jul 26, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Hongqing-work
commented
Jul 26, 2024
Comment on lines
+35
to
+45
| std::unordered_map<std::string, ::pir::Attribute> jit_kernel_attr = [&]() { | ||
| const auto& optional_broadcast_tree = GetBroadcastTreeForOptimize(group); | ||
| if (optional_broadcast_tree.has_value()) { | ||
| const std::shared_ptr<BroadcastTree> broadcast_tree = | ||
| optional_broadcast_tree.value(); | ||
| const auto& value_to_dim_expr_idx = | ||
| GetGroupDimExprInfo(group).value_to_dim_expr_idx; | ||
| return CompileBroadcastTree( | ||
| group, *broadcast_tree, value_to_dim_expr_idx); | ||
| } else { | ||
| return GetJitKernelAttr(group); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
当前PR暂时还是将Broadcast tree的编译放在ProcessDyShapeGroup中，下一个PR将直接放入GetJitKernelAttr函数的逻辑中并放入PreAnalysis增强系统可维护性
tc20042008
approved these changes
Jul 26, 2024
| @@ -35,12 +35,8 @@ std::optional<std::shared_ptr<BroadcastTree>> GetBroadcastTreeForOptimize( | |||
| bool ContainBroadcastShape(const common::BroadcastLeaf& leaves); | |||
| GroupDimExprInfo GetGroupDimExprInfo(const OpLoweringGroupPtr& group); | |||
|
|
|||
| pir::Operation* CompileBroadcastTreeToConditionBlock( | |||
| std::unordered_map<std::string, pir::Attribute> CompileBroadcastTree( | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CompileBroadcastTreeToJitKernelOpAttrs
函数签名发生了变化，名字必须做到名副其实。
| std::unordered_map<std::string, pir::Attribute>> | ||
| CompileGroupAsOpAttribute(const std::vector<OpLoweringGroupPtr>& group_list) { | ||
| std::unordered_map<std::string, pir::Attribute> | ||
| CompileBroadcastGroupsAsOpAttribute( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CompileBroadcastGroupsAsJitKernelOpAttribute
语义要表达到位
| ops_mapper[op] = new_op; | ||
| } | ||
|
|
||
| const int& group_idx) const { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const std::string& name_suffix
这个字段的作用太弱了，其实本函数需要的只是名字后缀。到时候直接把std::to_string(group_idx)传给本函数就行。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
收到，上述命名及变量问题都将在下一个PR中进行修改
zyfncg
approved these changes
Jul 26, 2024
Dale1314
pushed a commit
to Dale1314/Paddle
that referenced
this pull request
Jul 28, 2024
* [CINN]apply broadcast tree optimization * fix * fix unit test
lixcli
pushed a commit
to lixcli/Paddle
that referenced
this pull request
Aug 5, 2024
* [CINN]apply broadcast tree optimization * fix * fix unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
CINN
PR Types
Improvements
Description
Pcard-67164
This PR applies the optimization of broadcast tree lowering to host function.
To learn more about the theoretical explanation of lowering broadcast tree in host wrapper function and the step-by-step arrangement for the Pull Request (PR), please refer to the draft PR65604 for details.