| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 21:01:43 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=393.062161,conversation_content-fragment;desc="conversation_content fragment";dur=1400.986659,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=385.019486,nginx;desc="NGINX";dur=1.235093,glb;desc="GLB";dur=100.489199
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=i2DajoUGBfqxt3HfDDlIDTN96h2BLbMep%2BzVnpAQ7Iwd6foFzMysKsituqVAeC4CMgpYtH21%2BCnL6e0X%2B%2Bs5bnsbVVJKumQjbbJAiElE26CtHcq7L5%2F3WDLb10X1lHdsPSMuntko2A24sk5Csp8ljVdMHNNQWa6q4pQRGnQUk63KObD8RZ17otcqPjY3T0Ppec8zFZtRIyg3GuCMBTfMK6jk7GBulKUVGgzlAgO4%2BABdPWICR3mRZ9sx4j7%2B4PhFIgaffc7lIi938yKD7BVMsA%3D%3D--3j2yu7eS7mt%2FlTTf--p6Hq71t8RKA7gTbH%2BxoO5g%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1806723457.1753304502; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:01:42 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:01:42 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8CA4:351DD4:10B8CD8:13EB635:68814DB6
[PIR] remove xshape for reshape op by chen2016013 · Pull Request #66089 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[PIR] remove xshape for reshape op #66089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
chen2016013
commented
Jul 29, 2024
| spmd_rule : ReshapeInferSpmdDynamic | ||
| kernel : | ||
| func : reshape | ||
| func : reshape_infer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kernel动静统一之后应该统一为reshape
Aurelius84
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| @@ -731,7 +731,7 @@ std::shared_ptr<OpStrategy> StrategyForReshapeSymbolic( | |||
| << ", output_shapes: " << utils::Join(output_shapes[0], ", "); | |||
|
|
|||
| std::string tensor_name; | |||
| if (pack_args.size() == 4) { | |||
| if (pack_args.size() == 4 || pack_args.size() == 3) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里还会有 == 4 的场景么？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不会了，我之后删掉
zyfncg
reviewed
Jul 30, 2024
Comment on lines
+387
to
+390
| if (op->isa<paddle::dialect::ReshapeOp>()) { | ||
| match_ctx->BindIrValue(tensors[0]->name(), op->result(0)); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里加特判是不是不太合适？
| auto xshape_dims = xshape.dims(); | ||
| auto x_dims = common::slice_ddim(xshape_dims, 1, xshape_dims.size()); | ||
| auto grad_x_tmp = reshape<T>(grad_out, common::vectorize(x_dims)); | ||
| auto grad_x_tmp = reshape<T>(grad_out, common::vectorize(xshape_dims)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果xshape是动态维度这里会不会有问题？
| @@ -962,6 +962,14 @@ void KernelWithXShapeInferMeta(const MetaTensor& xshape, | |||
| dx->share_lod(xshape); | |||
| } | |||
|
|
|||
| void ReshapeGradInferMeta(const MetaTensor& xshape, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xshape这里应该就是x吧？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
单独提PR修改变量名
Comment on lines
+3105
to
+3107
| - op : reshape_grad (reshape2_grad) | ||
| inputs: | ||
| x : XShape |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
反向算子应该不用配置这个
XiaoguangHu01
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zyfncg
approved these changes
Jul 30, 2024
Closed
Lans1ot
pushed a commit
to Lans1ot/Paddle
that referenced
this pull request
Aug 5, 2024
* remove xshape for reshape op * remove xshape for reshape op * ignore dynamic * update * update * update * update * fix PT and prim bug * update * update * update * update * update * fix fusion pass bug * fix fusion pass bug * refine codestyle * update * update * update * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Operator Mechanism
PR Types
Not User Facing
Description
pcard-67164
pd_op.reshape（等系列算子）有xshape这一输出，记录输入 x 的 meta 信息用于反向输入。
xshape 在 cinn_op.reshpe 没有对应输出，导致一系列后续执行错误。直接去掉 xshape 无法满足 inplace 场景，原始 x 的 meta 信息会丢失。在 cinn_op 中添加 xshape 输出会引发其他问题且不够优雅。
在对inplace做改造后（前序PR：https://github.com/PaddlePaddle/Paddle/pull/65491）移除 reshape op 的 xshape 输出。