| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 04:25:43 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=349.35482,conversation_content-fragment;desc="conversation_content fragment";dur=1079.945822,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=345.742998,nginx;desc="NGINX";dur=1.147309,glb;desc="GLB";dur=101.815303
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=l1RFhnb3ZCDKB7cMGoLpveawJraw0TnXobh62C9IOvdhfCLtIWnOFimVNFHnP%2F8xTSXLScm3BZXkJ%2Fvy97sVY96%2FDjMuYa6aBqUC7DR3b7zxAhxAgGdRH0dkcFaYRj9Wh7yxE2mdThorS1vDTMElHyAa%2B%2BYfjlc5adHwzd%2BxXqKK1dhB5ceVY%2FQHqntTw5lE2y0TOOKjSRiFxgvTWBpuncZOujH6lkuqE5OxoPyGtyClm%2BGCYUcxJrRzwjDiWnHX%2F99PCkv76FyXfw6AXzPIXQ%3D%3D--D%2BDLh4kLgWOCusoa--SJ4jTR5x6IYPPDPhDeeKIg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1190202462.1753331141; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:25:41 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:25:41 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DD68:18BEF9:313C25:445E7A:6881B5C5
Merge eager_generator by tianshuo78520a · Pull Request #66083 · PaddlePaddle/Paddle · GitHub
tianshuo78520a
dismissed stale reviews from risemeup1 and wanghuancoder
via
July 22, 2024 06:11
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Merge eager_generator #66083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Merge eager_generator #66083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
paddle/fluid/pybind/CMakeLists.txt
Outdated
| set(EAGER_CODEGEN_DEPS eager_generator) | ||
| if("${CMAKE_GENERATOR}" STREQUAL "Ninja") | ||
| set(eager_generator_path "${CMAKE_CURRENT_BINARY_DIR}") | ||
| message(1111, ${eager_generator_path}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这行想着删掉
paddle/fluid/pybind/CMakeLists.txt
Outdated
| else() | ||
| set(eager_generator_path | ||
| "${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_BUILD_TYPE}") | ||
| message(2222, ${eager_generator_path}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里也是
paddle/fluid/pybind/CMakeLists.txt
Outdated
| @@ -438,7 +577,7 @@ if(WITH_PYTHON) | |||
| add_custom_command( | |||
| OUTPUT ${eager_impl_file} | |||
| COMMAND | |||
| ${CMAKE_BINARY_DIR}/paddle/fluid/pybind/eager_legacy_op_function_generator_retry.bat | |||
| ${CMAKE_BINARY_DIR}/paddle/fluid/pybind/eager_generator_retry.bat | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里是前面生成的bat，你前面生成的文件名还是eager_legacy_op_function_generator_retry，Windows是找不到eager_generator_retry.bat的
paddle/fluid/pybind/generator.cc
Outdated
Comment on lines
19
to
27
| int main(int argc, char* argv[]) { | ||
| if (argc == 2) { | ||
| run_legacy_generator(argc, argv); | ||
| } else if (argc == 3) { | ||
| run_generator(argc, argv); | ||
| } else { | ||
| std::cerr << "argc must be 2 or 3" << std::endl; | ||
| return -1; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里加一下注释，2是用来生成啥的，3是用来生成啥的。
wanghuancoder
previously approved these changes
Jul 19, 2024
risemeup1
previously approved these changes
Jul 22, 2024
tianshuo78520a
dismissed stale reviews from risemeup1 and wanghuancoder
via
81d892c
risemeup1
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
phlrain
approved these changes
Jul 23, 2024
tianshuo78520a
added a commit
to tianshuo78520a/Paddle
that referenced
this pull request
Jul 23, 2024
This reverts commit 04918d8.
zhwesky2010
pushed a commit
that referenced
this pull request
Jul 23, 2024
skywalker2012
pushed a commit
to skywalker2012/Paddle
that referenced
this pull request
Jul 24, 2024
* Fix * Fix * Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Others
PR Types
Others
Description
eager_legacy_op_function_generator 合并到eager_generator 中，减少Build目录大小，约2.1G
Pcard-67012