| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 00:44:51 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=239.981764,conversation_content-fragment;desc="conversation_content fragment";dur=1086.625136,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=300.7747,nginx;desc="NGINX";dur=0.647054,glb;desc="GLB";dur=101.329103
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=MTYLYGfraiy32p8afo8RUjFgTN%2F6s0rGUxdOyF9%2FOx4HV%2FmO%2BXbP4Kv5G8SfyAppx0z%2F5ZEihQO4%2Bz7%2FCgTgMRS0px%2FiV%2F%2Fb9SwMUP%2BaKr6LRW1CSwAEm6jqgnJT8ZdSVJsMknSJSQQ8rafL7gge%2FFxXgNZ%2Bwo7%2B0%2BKtWL4cutk4bDNmW9%2FqEyzn1Gxgo9hTa9nLRdXfpMB1b5k324O7gNc2Km%2FHGARGxTajaNEwP0%2BKLcOF49YecyT4NlYeybpsqeBsLHATYxeP%2FNP4pWSIEQ%3D%3D--1Qmuasipqqfb%2BPuN--I4Oj9D%2Bqna9jhX4DSYnjDQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1409976107.1753490689; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 00:44:49 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 00:44:49 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C90C:3B05D7:64044:A0A3B:68842501
support none input for saved_for_backward hook by Difers · Pull Request #65879 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
support none input for saved_for_backward hook #65879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
deepllz
reviewed
Jul 10, 2024
| @@ -590,6 +590,10 @@ void call_pack_hook(PyLayerObject* self, PyObject* value) { | |||
| saved_value = value; | |||
| } else if (PyList_Check(value)) { | |||
| saved_value = PyList_AsTuple(value); | |||
| } else if (value == Py_None) { | |||
| saved_value = PyTuple_New(0); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里new的size为什么是0呢？
| @@ -346,6 +346,8 @@ def inner_pack(inner_x): | |||
|
|
|||
| if holder_list[unpack_counter - 1]() is None: | |||
| return | |||
| if inner_x is None: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里是不是少了else分支
deepllz
reviewed
Jul 10, 2024
| @@ -368,7 +371,10 @@ def inner_pack(inner_x): | |||
| inner_x.persistable, | |||
| ) | |||
| inner_x._unsafe_share_buffer_to(tmp_tensor) | |||
| storage[holder_list[unpack_counter - 1]()] = tmp_tensor | |||
| if hasattr(inner_x, "main_grad"): | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个分支不再需要tmp_tensor，可以把这个判断往前挪到tmp_tensor创建之前。
deepllz
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wanghuancoder
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lixcli
pushed a commit
to lixcli/Paddle
that referenced
this pull request
Jul 22, 2024
* support none * refine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Operator Mechanism
PR Types
New features
Description
Pcard-85260
当前saved_for_backward hook在recompute不支持输入为None
但当前组网中会有相关case，例如：
https://github.com/PaddlePaddle/PaddleNLP/blob/fbe613bbc53df5af9e36dd9f9f0491f0651427e0/llm/utils/fused_layers.py#L36
在开启enable_linear_fused_grad_add及recompute时即会触发报错
该PR修改了pack/unpack 及recompute hook 以支持输入为None.
自测记录：在开启enable_linear_fused_grad_add下开关recompute进行对齐
workerlog_recompute_true.log
workerlog_recompute_false.log