| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 21:03:37 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=296.556768,conversation_content-fragment;desc="conversation_content fragment";dur=948.642546,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=347.507956,nginx;desc="NGINX";dur=0.568589,glb;desc="GLB";dur=101.273487
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=rMhgJN7QCrzPA5a%2F%2BlrTYyQkn7Q2Ht8JyfEVZYdyBxJRrYQ5DPVUleQp%2BZyfeZ1W3FJHUl3sGkfZdGzP3R9%2BYAJ3LIWeaAW5EyST30S5thb1N3RrCGAdf8C7MLhK%2FDssnPb2hfXg8NOoa2WcuCYGPDIQIQoKVmcWs7YmtyW%2BoAJw9dK98nOIDRBYs7j%2FjjQAWfpg1UOCRb2fgXRWbdk%2F3dJzwDpgIBLrlAdxbqE1hNoIiKxPRR5gIqXlHafjpijdz5rs%2BouWsquWhp2ov8hdBw%3D%3D--ZXGKZ08KzqfycsOO--gRTR8pTsOIbpHxNLDbEQ9A%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.998453344.1753304616; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:03:36 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:03:36 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9824:3F8A98:F872D:147CBF:68814E28
[CINN]support codegen for switch<HostFunc> by Hongqing-work · Pull Request #65669 · PaddlePaddle/Paddle · GitHub
Hongqing-work
changed the title
[CINN]support codegen for switch<NaiveHostFunc>
[CINN]support codegen for switch<HostFunc>
Jul 8, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[CINN]support codegen for switch<HostFunc> #65669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Hongqing-work
merged 2 commits into
PaddlePaddle:develop
from
Hongqing-work:broadcast-tree-s1
Jul 8, 2024
Merged
[CINN]support codegen for switch<HostFunc> #65669
Hongqing-work
merged 2 commits into
PaddlePaddle:develop
from
Hongqing-work:broadcast-tree-s1
Jul 8, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
BiynXu
previously approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zyfncg
reviewed
Jul 5, 2024
| * CodeGenSwitchHost takes a CINN Module with switch<NaiveHostFunction> | ||
| * functions and output a LLVM module. | ||
| */ | ||
| class CodeGenSwitchHost : public CodeGenHostBase { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch该怎么解释，适合哪些场景使用
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| namespace backends { | ||
|
|
||
| /** | ||
| * CodeGenSwitchHost takes a CINN Module with switch<NaiveHostFunction> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NaiveHostFunction这个概念目前还没有出现过，这里最好解释一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已重新组织层级并解释
Hongqing-work
changed the title
zyfncg
approved these changes
Jul 8, 2024
tc20042008
approved these changes
Jul 8, 2024
tc20042008
reviewed
Jul 8, 2024
Comment on lines
+28
to
+29
| * InvokeFunc = HostFunc | Switch<HostFunc> | ||
| * HostFunc = X86Func | CudaHostFunc | HipHostFunc | ...... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些注释和代码对应关系很弱，名字上对应的不强烈。尤其是Switch的这个写法。
你应该把CodeGenSwitchHost直接写成Switch的形式。
template <T>
class Switch;
template<>
class Switch<CodeGenHost> : ... {
...
};
对于InvokeFunc = HostFunc | Switch这一注释，要么改注释，要么改代码，一定要保持一致，否则维护起来就是个灾难。
| * CodeGenInvokeModule takes a CINN invoke Module(a module that only contains | ||
| * functions that jit instructions actually invoke) and output a LLVM module. | ||
| */ | ||
| class CodeGenInvokeModule : public CodeGenLLVM { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个Invoke语义太弱了，没有提供什么信息量。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
CINN
PR Types
New features
Description
Pcard-67164
This PR adds support for codegen of switch, which is the first step for lowering broadcast tree.
To learn more about the theoretical explanation of lowering broadcast tree in host wrapper function and the step-by-step arrangement for the Pull Request (PR), please refer to the draft PR65604 for details.