| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 02:27:19 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=307.395107,conversation_content-fragment;desc="conversation_content fragment";dur=1046.648855,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=385.477183,nginx;desc="NGINX";dur=1.459111,glb;desc="GLB";dur=101.578194
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=wJVlDjrQw83Uf8onbVMJelYBAkGxb5OnOoGBZLHPmvd9wR%2B6T1xE5N8zn0ZA%2BGyt2Z0XivQ%2FD3CMWWAQ9IPzZ%2F3NipMfGCXm3stVFBmOWXSX1hP7sqQkk9r21bBFBbbYaACawY9ADF2XO9jdJxGZTMJvughQK6Y4fk48UZUH36htTOx6D1eSYywlNZ%2B7uXSw5xhzbd4CIx6MmZiLiXkFzE2PA%2BNR%2BdBq4Nk5wsYoiuT%2F11iRRwlwznhogOYky5NHTta4ILbV3oszfyA6kPDVCw%3D%3D--cvOOlIsd90JbNyeY--kzvyVdplzxAzbtZ%2BMcxKJw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.179971782.1753496838; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 02:27:18 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 02:27:18 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D784:29FD1F:C315A:134235:68843D06
[Typing] 修改 core.pyi 及一些示例代码中的类型错误 by megemini · Pull Request #65496 · PaddlePaddle/Paddle · GitHub
megemini
requested review from
XiaoguangHu01,
zhiqiu,
Xreki,
qili93 and
Aurelius84
as code owners
June 26, 2024 12:47
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[Typing] 修改 core.pyi 及一些示例代码中的类型错误 #65496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megemini
requested review from
XiaoguangHu01,
zhiqiu,
Xreki,
qili93 and
Aurelius84
as code owners
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Jun 26, 2024
python/paddle/base/core.pyi
Outdated
| @@ -26,23 +28,39 @@ class Place: | |||
| def set_place(self, place: Place) -> None: ... | |||
| def xpu_device_id(self) -> int: ... | |||
|
|
|||
| class CPUPlace(Place): ... | |||
| class CPUPlace: ... | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里不「继承」，也不「实现」的话，怎么保证 CPUPlace() 可以传入 foo(p: Place) 呢？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
咱们有个
PlaceLike: TypeAlias = Union[
"CPUPlace",
"CUDAPlace",
"CUDAPinnedPlace",
"IPUPlace",
"CustomPlace",
"XPUPlace",
str, # some string like "cpu", "gpu:0", etc.
]是不是应该用这个？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
那……Place 的意义是啥啊 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不知道 ... ... 可能有地方单独需要 Place 的一些方法？
class Place(Protocol):
def custom_device_id(self) -> int: ...
def custom_device_type(self) -> str: ...
def gpu_device_id(self) -> int: ...
def ipu_device_id(self) -> int: ...
def is_cpu_place(self) -> bool: ...
def is_cuda_pinned_place(self) -> bool: ...
def is_custom_place(self) -> bool: ...
def is_gpu_place(self) -> bool: ...
def is_ipu_place(self) -> bool: ...
def is_xpu_place(self) -> bool: ...
def set_place(self, place: Place) -> None: ...
def xpu_device_id(self) -> int: ...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
所以为啥不实现呢？
所有 Place 实现这个 Place 不可以么？
然后我们是不是可以用 PlaceLike: TypeAlias = Union[Place, str]？
Update 20240626
|
SigureMo
reviewed
Jun 26, 2024
| @@ -54,7 +54,7 @@ def __init__( | |||
| oup: int, | |||
| stride: int, | |||
| expand_ratio: float, | |||
| norm_layer: nn.Layer = nn.BatchNorm2D, | |||
| norm_layer: type[nn.Layer] = nn.BatchNorm2D, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是不是和 #65487 做重了？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
哦？好像当时还只看到 mobilenetv3 ～ 我撤掉就行 ～
Update 20240627
|
SigureMo
previously approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow
喔喔，还有点问题 |
居然影响到这里 ... ... 防不胜防 ～～～ |
SigureMo
approved these changes
Jun 27, 2024
Aurelius84
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
User Experience
PR Types
Bug fixes
Description
core.pyi中XXXPlace不再继承Placecore.pyi一些类及方法关联 PR #65008 #65397
@SigureMo