| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 02:27:28 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=205.791527,conversation_content-fragment;desc="conversation_content fragment";dur=934.324081,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=268.137206,nginx;desc="NGINX";dur=0.864749,glb;desc="GLB";dur=101.366749
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=1o9eELv3A3urCo0LB2WPF42qj0XkIBxbvRIgu8PsulyRaDqgGsaRCwvlhLObzQE5v3KbOx2iBciKN8yzjC9v1DTnr9kL1xlANL2sACn4lM71LSGslSbj6GfqDyC2WnMwmStIx1bH8M3zSNZ5JvWC2n30rermTxX%2B0SR7z9YvqAOdp3R5P1oFd1dAeSG%2F6nDQU1bAicwMEY2yCDUIYuAMLH1FHgw%2ByAk3anawjP08voctCBAbIPCaOy13YLWGlhlDaHskc0dyaI5mpi1R%2FgGWBA%3D%3D--Y52KrMc6AZ87mqeg--n3Q6TfISigBTCwQVMPeWXg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.360916721.1753496847; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 02:27:27 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 02:27:27 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C0FC:37D5F1:C4216:13545A:68843D0F
[CINN]add CacheGradOpSymbolicShapeInterface by Hongqing-work · Pull Request #65343 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[CINN]add CacheGradOpSymbolicShapeInterface #65343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Hongqing-work
merged 7 commits into
PaddlePaddle:develop
from
Hongqing-work:add-backward-cache-interface
Jun 27, 2024
Merged
[CINN]add CacheGradOpSymbolicShapeInterface #65343
Hongqing-work
merged 7 commits into
PaddlePaddle:develop
from
Hongqing-work:add-backward-cache-interface
Jun 27, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
…ckward-cache-interface
zyfncg
reviewed
Jun 24, 2024
| @@ -113,7 +125,7 @@ void ApplyCinnPreprocessPass( | |||
| bool has_dynamic_shape = HasDynamicShape(*program); | |||
|
|
|||
| if (has_dynamic_shape) { | |||
| pass_manager->AddPass(pir::CreateShapeOptimizationPass()); | |||
| // pass_manager->AddPass(pir::CreateShapeOptimizationPass()); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注释可以删掉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Comment on lines
+19
to
+21
| namespace paddle::dialect { | ||
| using CacheGradOpSymbolicShapeInterface = | ||
| pir::CacheGradOpSymbolicShapeInterface; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个inferface是否有必要包一层paddle::dialect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CacheGradOpSymbolicShapeInterface属于op接口最好放在paddle::dialect，但是和符号推导接口类似，由于pir目录下的shape_optimization_pass需要使用，而pir不能引用paddle::dialect，所以放在pir中了。
Comment on lines
309
to
353
| const auto& CacheSelfSymbolicShape = [&]() { | ||
| std::vector<symbol::ShapeOrDataDimExprs> result_shape_or_data; | ||
| for (auto& result : op->results()) { | ||
| result_shape_or_data.emplace_back( | ||
| infer_context->GetShapeOrDataForValue(result)); | ||
| } | ||
| if (infer_context->GetOpInferSymbolicShapeCache(op_infer_cache_key) | ||
| .has_value()) { | ||
| std::vector<symbol::ShapeOrDataDimExprs> cached_result_shape_or_data = | ||
| infer_context->GetOpInferSymbolicShapeCache(op_infer_cache_key) | ||
| .value(); | ||
| // check whether the result_shape_or_data is consistent with the cached | ||
| // TODO(Hongqing-work): delete check and only set cache for op without | ||
| // InferSymbolicShapeInterface after fixing all warnings. | ||
| if (cached_result_shape_or_data.size() != result_shape_or_data.size()) { | ||
| LOG(WARNING) << "cached shape is not consistent with real shape"; | ||
| } else { | ||
| for (uint32_t i = 0; i < op->num_results(); ++i) { | ||
| if (cached_result_shape_or_data[i] != result_shape_or_data[i]) { | ||
| LOG(WARNING) << "cached shape is not consistent with real shape"; | ||
| VLOG(3) << "InferSymbolicShapeCacheKey is: " << op_infer_cache_key; | ||
| VLOG(3) << "cached shape is: " << cached_result_shape_or_data[i]; | ||
| VLOG(3) << "real shape is: " << result_shape_or_data[i]; | ||
| } | ||
| } | ||
| } | ||
| } else { | ||
| infer_context->SetOpInferSymbolicShapeCache(op_infer_cache_key, | ||
| result_shape_or_data); | ||
| } | ||
| }; | ||
|
|
||
| const auto& CacheGradOpSymbolicShape = [&]() { | ||
| auto cache_grad_op_symbolic_shape_interface = | ||
| op->dyn_cast<pir::CacheGradOpSymbolicShapeInterface>(); | ||
| if (cache_grad_op_symbolic_shape_interface) { | ||
| VLOG(3) << "CacheGradOpSymbolicShape for: " << op->name(); | ||
| PADDLE_ENFORCE_EQ( | ||
| cache_grad_op_symbolic_shape_interface.CacheGradOpSymbolicShape( | ||
| infer_context), | ||
| true, | ||
| "CacheGradOpSymbolicShape for %s failed.", | ||
| op->name()); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是不可以直接拆成两个函数？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
tc20042008
reviewed
Jun 26, 2024
| void InferSymExprForOp(Operation* op, | ||
| InferSymbolicShapeContext* infer_context, | ||
| const InferSymbolicShapeCacheKey& op_infer_cache_key) { | ||
| auto infer_symbolic_shape_interface = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const auto&
不要养成使用auto的习惯。最多能用auto*和const auto&
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里需要调用非const函数，和其它接口保持一致，所以做此折中
| } | ||
| } | ||
|
|
||
| void CacheSelfSymbolicShape( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个Self语义不明
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改为forward和backward
| LOG(WARNING) << "cached shape is not consistent with real shape"; | ||
| } else { | ||
| for (uint32_t i = 0; i < op->num_results(); ++i) { | ||
| if (cached_result_shape_or_data[i] != result_shape_or_data[i]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
到这里已经是三层if了。
既然从第二层if到这里的逻辑都只是check，那就专门提一个check函数。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
tc20042008
approved these changes
Jun 27, 2024
zyfncg
approved these changes
Jun 27, 2024
zhangbo9674
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
CINN
PR Types
New features
Description
Pcard-67164
This PR adds CacheGradOpSymbolicShapeInterface.