| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 23:49:19 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=281.34453,conversation_content-fragment;desc="conversation_content fragment";dur=793.872479,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=299.297895,nginx;desc="NGINX";dur=1.507327,glb;desc="GLB";dur=102.080296
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=Lww%2F0jGtN9R4IGkhuTSYZJ%2Bqmy7omZFGQqhZVwV%2BEXXCPwVFgmpJhkzvoAcUcfmBBQ6RwpP7dwminXN3pn4x970uAlp0N3ocF%2BMyixAwue9G8QEK8Rv49mW1v8CZQYix9ZfpzNLClPfpIPBwpE%2FWJo7D9rmthpDZG8g1cY7zqNvXXnM3ascTiw%2FFxWZs91lnRsZ4rn22DJ39K6nV7RNeFBOn6yOjAFU%2BnQ3tJjMS9FIY%2B%2F4sKT4rxyYOsZAEYSC38ZEB3V%2Bj2EkCqX4AkxtuWA%3D%3D--0CERMwsLMc9o1Qtf--Ou83zsnCfgQwoWTAtleECA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.492361358.1753400958; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 23:49:18 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 23:49:18 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D648:167D14:1F9C6:3212B:6882C67E
[Serde] Add warning if saved model output contains dict by SigureMo · Pull Request #65296 · PaddlePaddle/Paddle · GitHub
SigureMo
deleted the
serde/add-warning-if-saved-model-output-contains-dict
branch
June 20, 2024 08:32
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[Serde] Add warning if saved model output contains dict #65296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 3 commits into
PaddlePaddle:develop
from
cattidea:serde/add-warning-if-saved-model-output-contains-dict
Jun 20, 2024
Merged
[Serde] Add warning if saved model output contains dict #65296
SigureMo
merged 3 commits into
PaddlePaddle:develop
from
cattidea:serde/add-warning-if-saved-model-output-contains-dict
Jun 20, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
python/paddle/jit/api.py
Outdated
| @@ -648,6 +656,10 @@ def _get_output_vars(outputs, output_spec, with_hook=False): | |||
| "Currently not support specify output_spec while founding pre/post hooks in your outermost layer." | |||
| ) | |||
| result_list = [] | |||
| if _contains_dict(outputs): | |||
| warnings.warn( | |||
| "Outputs of save model contains dict, we will flatten it to list, and sort it by alphabet order." | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_get_output_vars这个函数应该不只是简单地flatten，而是返回按照keys字典序排序的values序列，然后打印的语句感觉不是很书面，比如 we will 这种描述。是否可以改成这样：Find 'dict' in given outputs, the values will be returned in a sequence sorted in lexicographical order by their keys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改～
| @@ -499,6 +500,7 @@ def tearDown(self): | |||
|
|
|||
| @test_with_dygraph_pir | |||
| def test_output_same_order(self): | |||
| model_path = os.path.join(self.temp_dir.name, "./dict_out_model") | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
此处是不是可以去掉./
| with warnings.catch_warnings(record=True) as w: | ||
| paddle.jit.save(st_model, model_path) | ||
| self.assertIn( | ||
| "Outputs of save model contains dict, we will flatten it to list, and sort it by alphabet order.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果上面字符串修改的话，这里也改一下
| def test_nested_output_same_order(self): | ||
| model_path = os.path.join(self.temp_dir.name, "./nested_dict_out_model") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上，./可以删除？
HydrogenSulfate
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SigureMo
deleted the
serde/add-warning-if-saved-model-output-contains-dict
branch
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Improvements
Description
当
jit.save的模型输出包含 dict 时，需要报 warning，相关 PR：#65268、#63791cc @HydrogenSulfate
PCard-66972