| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 23:48:53 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=311.390399,conversation_content-fragment;desc="conversation_content fragment";dur=1774.14082,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=415.432987,nginx;desc="NGINX";dur=1.498579,glb;desc="GLB";dur=100.815588
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=xtQm2WMrrixQAtS5TPM%2B8v3uxP7LeGLqQFScKc2nSUCyil6W4%2F50vUQGa8KAIchG77Qr6DTKzPijYvUeFwfq35QJXCGFEayKlULKwxgBuGoYf%2BXvn2A3gKRhOZuxF8tAiUK%2FeplAk%2BhA57dyjyK9woVqokU%2Bcwd9uVwWpdOxQeakdQhMHdGH2dCNYhdZt1zJhaA7EhExrw%2B3UlL1Kz5Luh3TKMevjLN5lWFZu0FUjLCZ3iMu3C5hiNAWHA8Tc4a0xTjo7KeBRHS%2FO4lG52pA1g%3D%3D--QdEapcaRWc%2BzyhIo--nY%2FCQgPIRadCFkbPo9nEdg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1305897672.1753400931; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 23:48:51 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 23:48:51 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BE40:9D20F:1F878:31D1B:6882C663
[CINN][New Hardware Update] HIP first PR by DongBaiYue · Pull Request #65146 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[CINN][New Hardware Update] HIP first PR #65146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
tc20042008
reviewed
Jun 14, 2024
| @@ -100,6 +100,8 @@ const Target& DefaultHostTarget(); | |||
|
|
|||
| const Target& DefaultNVGPUTarget(); | |||
|
|
|||
| const Target& DefaultHygonDcuHipTarget(); | |||
|
|
|||
| const Target& DefaultDeviceTarget(); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个函数和DefaultTarget的差异是啥？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看起来目前DefaultDeviceTarget()与DefaultTarget()功能相同，后面可考虑移除其中一个。
* add cinn::common::HygonDCUArchHIP * implement HygonDCUArchHIP branchs * some branches are not implemented. * introduce cinn::runtime::BackendAPI. It is a temporary implementation, will be replaced by paddle::phi::backends after resolving circular dependencies.
tc20042008
previously approved these changes
Jun 21, 2024
paddle/cinn/runtime/hip/hip_util.h
Outdated
| namespace runtime { | ||
| namespace hip { | ||
|
|
||
| #define HIP_CALL(func) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
【下一个pr重构】重命名成HIP_CHECK(expr)
paddle/cinn/runtime/hip/hip_util.h
Outdated
| } \ | ||
| } | ||
|
|
||
| #define HIP_DRIVER_CALL(func) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
【下一个pr重构】重命名成HIP_DRIVER_CHECK(expr)
paddle/cinn/runtime/hip/hip_util.h
Outdated
| } \ | ||
| } | ||
|
|
||
| #define HIPRTC_CALL(func) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
【下一个pr重构】重命名成HIPRTC_CHECK(expr)
| @@ -30,10 +30,13 @@ struct ARMArch {}; | |||
|
|
|||
| struct NVGPUArch {}; | |||
|
|
|||
| struct HygonDCUArchHIP {}; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
【下一个PR重构】
define CINN_ARCH_CLASS_NAMES(_macro) \
_macro(X86Arch) \
_macro(ARMArch) \
_macro(NVGPUArch) \
_macro(HygonDCUArchHIP)
#define DEFINE_CINN_ARCH(class_name) struct class_name {};
CINN_ARCH_CLASS_NAMES(DEFINE_CINN_ARCH);
#undef DEFINE_CINN_ARCH
| /** | ||
| * The architecture used by the target. Determines the instruction set to use. | ||
| */ | ||
| using ArchBase = std::variant<UnknownArch, X86Arch, ARMArch, NVGPUArch>; | ||
| using ArchBase = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
【下一个PR重构】
using ArchBase = std::variant<
#define LIST_CINN_ARCH_ALTERNATIVE(class_name) class_name,
CINN_ARCH_CLASS_NAMES(LIST_CINN_ARCH_ALTERNATIVE)
#undef LIST_CINN_ARCH_ALTERNATIVE
UnknownArch
>;
tc20042008
approved these changes
Jun 25, 2024
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Jun 25, 2024
* [CINN][New Hardware Update] add HygonDCUArchHIP * add cinn::common::HygonDCUArchHIP * implement HygonDCUArchHIP branchs * some branches are not implemented. * introduce cinn::runtime::BackendAPI. It is a temporary implementation, will be replaced by paddle::phi::backends after resolving circular dependencies. * [CINN][new hardware] modify not implement info * [CINN][new hardware] tile HygonDCUArchHIP * fix compile * fix compile v2 * fix format * fix codestyle * fix approval * fix compile v3 * fix setNvHygon() * Fix APPROVAL : CHECK and LOG(FATAL) * Fix APPROVAL : CHECK * fix compile * fix backendAPI compile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
CINN
PR Types
New features
Description
HIP后端第一个PR
pcard-79890