| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 05:52:21 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=375.967998,conversation_content-fragment;desc="conversation_content fragment";dur=730.470236,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=420.195881,nginx;desc="NGINX";dur=1.416151,glb;desc="GLB";dur=101.629042
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=nv1mc22TUClZ0nIRG5Ia%2Bbb3eY8NHRRFXH9uyefSZrL%2BhKuKY9BWxUoBUv3a%2BU1WGdLksDah9u%2B2E58SjhAV202Lt%2BBdXk1M5xNSyM3gKE8LErrropHImjLoFm5MVZbcpGlwVukEL0lBGd%2B8EdE6CYDg3Kkm2ZXl0ozDcgM%2F27Dsd9%2BmWQJsEgc2LJH8TVUsbR9pKkNdFOiYKQzoe2QXDfAPp0ZUnnzD2X%2FreTxhlSe6JG%2BKHlljQM8PyUvcdl80gxCyrLy9nVP%2BrDMcX79eIg%3D%3D--KBXjVJHLqb2hqzte--AxQ4GMbrFPtQRVMLumnXgA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1495713100.1753422740; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 05:52:20 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 05:52:20 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A49C:0A55:217EEC:28C434:68831B94
[Infra] Request typing group review for API annotation only change by SigureMo · Pull Request #64812 · PaddlePaddle/Paddle · GitHub
SigureMo
requested review from
risemeup1,
zhangbo9674 and
XieYunshen
as code owners
June 1, 2024 10:56
SigureMo
deleted the
infra/request-typing-group-review-for-api-annotation-only-change
branch
June 3, 2024 10:34
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[Infra] Request typing group review for API annotation only change #64812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 25 commits into
PaddlePaddle:develop
from
cattidea:infra/request-typing-group-review-for-api-annotation-only-change
Jun 3, 2024
Merged
[Infra] Request typing group review for API annotation only change #64812
SigureMo
merged 25 commits into
PaddlePaddle:develop
from
cattidea:infra/request-typing-group-review-for-api-annotation-only-change
Jun 3, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
requested review from
risemeup1,
zhangbo9674 and
XieYunshen
as code owners
tianshuo78520a
approved these changes
Jun 3, 2024
risemeup1
approved these changes
Jun 3, 2024
SigureMo
deleted the
infra/request-typing-group-review-for-api-annotation-only-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Environment Adaptation
PR Types
Not User Facing
Description
修改 API diff 检查脚本，在仅仅发生 annotations 变动时，由 @SigureMo 等人来 review，提高后续 review 效率
assert_api、assert_api_approvals已无调用处的 CI 入口tools/print_signatures.py支持传入--show-fields参数，以允许将 spec 拆为.api（除了类型提示和文档）、.annotations（仅类型提示）、.doc（仅文档）三个文件，以允许细粒度地分发类型提示的 approval（以前是拆分成文档和非文档两部分）tools/print_signatures.py清理死代码tools/print_signatures.py--skipped默认值添加pir.ops，避免生成每个 PIR 的 OP 都触发 API 的 approval 检查tools/print_signatures.py到/tmp，以确保生成 signatures 时，PR 和 develop 上跑的tools/print_signatures.py是同一个脚本PCard-66972
Test Plan