You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current constraints of pass are not enough, and it will fuse some ops inappropriately (like fusing multi-dimension bias into conv, and the fused op will fail at dimension check). Hence we add new constraint to avoid such situations.
Also refined FusedConvTransposeAddFusePattern, since when ConvTransposeBiasFusePattern exists, the former one will never be executed.
你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.
Hi, about ConvBiasFusePass, I have some questions. In previous pass( non-pir implementation), I run ResNet50, and found it not fused in conv_bias pass, but fused in conv_elementwise_add pass. But if I run ResNet50 with PIR pass, it will fused in conv_bias pass. Your fix will constraint condition and make it not fused in conv_bias pass, but I notice after you fix, it still not be fused in conv_elementwise_add pass. So can you check it? Why conv bias/ conv elementwise is it different from the previous non-pir strategy? I'm not sure if our implementation is actually different or wrong under PIR than before.
Hi, about ConvBiasFusePass, I have some questions. In previous pass( non-pir implementation), I run ResNet50, and found it not fused in conv_bias pass, but fused in conv_elementwise_add pass. But if I run ResNet50 with PIR pass, it will fused in conv_bias pass. Your fix will constraint condition and make it not fused in conv_bias pass, but I notice after you fix, it still not be fused in conv_elementwise_add pass. So can you check it? Why conv bias/ conv elementwise is it different from the previous non-pir strategy?
Since I only added constraints for conv_bias_fuse_pass, it should not block fusion of conv_elementwise_add_pass. Did you re-run it when disabling bias pass? I guess the result will still be the same (add pass is not fused). But yes, I will check if there is any difference between pir pass and fluid pass of the conv_elementwise_add_pass as the following issue, thx~
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Others
PR Types
Bug fixes
Description
Current constraints of pass are not enough, and it will fuse some ops inappropriately (like fusing multi-dimension bias into conv, and the fused op will fail at dimension check). Hence we add new constraint to avoid such situations.
Also refined
FusedConvTransposeAddFusePattern
, since whenConvTransposeBiasFusePattern
exists, the former one will never be executed.