| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 06:32:25 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=318.635708,conversation_content-fragment;desc="conversation_content fragment";dur=838.311434,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=374.561219,nginx;desc="NGINX";dur=0.886142,glb;desc="GLB";dur=105.779031
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=sgSNcW8XwO4lfPviR9DDMwBHCGdhDOsPU8MJdXqLVmz8EcjF%2B1tkcl8ZD%2BFhHd9B97RiPjg7JPQwTIN2cerDBqmryAcPReSZ4GWf2y14e5NS04Qxa3ThgrIZZjZySO%2B%2FzuSOwzdmWxRlSjZG8aa125pEccautOW5a5TIEdbWlDi94BOmv%2B7edUoWHVqpJrxrowb5miKyj%2FJTtM4kDnfGK0hM0KBkdMlbxCnQB7i%2FnvFfzJoIhiG3v7CklaUveisVG%2FgSm3KU1DLkrTeANFKaQA%3D%3D--kib%2Byzs80zgBPHsf--sfvbBXVExpQLWlqubSqiXg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.505441084.1753425144; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:32:24 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:32:24 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 81FC:2B2ABB:371CD0:450E0A:688324F8
[DistDialect] Add pir nd_mesh reshard function by pkuzyc · Pull Request #64223 · PaddlePaddle/Paddle · GitHub
pkuzyc
force-pushed
the
pir_nd_mesh_reshard_func
branch
from
May 14, 2024 04:03
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[DistDialect] Add pir nd_mesh reshard function #64223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
pkuzyc
force-pushed
the
pir_nd_mesh_reshard_func
branch
from
b9c8492 to
70a008f
Compare
JZ-LIANG
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| self.run_pr_to_rs_case() | ||
| self.run_pr_to_ss_case() | ||
| self.run_ss_to_ss_case() | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add test for ss_to_rr, rs_to_sr (shard in same mesh dim and diff mesh dim) in future.
| dist_input, self._mesh1, output_placements | ||
| ) | ||
| dist_program = main_program.clone() | ||
| apply_reshard_pass(dist_program) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cross mesh scenario should call apply_partition_pass first to remove operation not belong to cur rank. (fix in next PR)
| # Calculate local shape. In nd_mesh_reshard, multiple tensor axis | ||
| # may be shard and it will call this 1-D s_to_r function on each | ||
| # axis. In this case, we should recompute the local and global shape. | ||
| out_local_shape = list(in_value.shape) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be better to regard the intermediate results within reshard transformation as local tensor and there is not need to assign dist_attr to it.
| test_pir_reshard_nd_mesh_func MODULES test_pir_reshard_nd_mesh_func ENVS | ||
| "http_proxy=;https_proxy=;PYTHONPATH=../..:${PADDLE_BINARY_DIR}/python") | ||
| set_tests_properties(test_pir_reshard_nd_mesh_func | ||
| PROPERTIES TIMEOUT "35" LABELS "RUN_TYPE=HYBRID") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
timeout 35 might be to short, it is better to setting timeout as 90 for 4 gpus unitests take into account the overhead of communicators initialization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In local test it costs about 10s, it can be updated when adding more cases in the future.
XieYunshen
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Auto Parallel
PR Types
New features
Description
Pcard-67164
Add nd_mesh reshard function in PIR, e.g. [Shard(0), Shard(1)] --> [Shard(1), Shard(0)]:
Find the tensor dimensions where the dims_mapping values differ between src_dist_attr and dst_dist_attr.
From higher to lower, convert the input tensor's non-replicated dimensions in step1 to replicated ([Shard(0), Shard(1)] --> [Shard(0), Replicate()] --> [Replicate(), Replicate()]):
Convert the replicated dimensions in step2 to the status in dst_dist_attr with corresponding ([Replicate(), Replicate()] --> [Replicate(), Shard(0)] --> [Shard(1), Shard(0)]):