| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 06:36:57 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=337.231121,conversation_content-fragment;desc="conversation_content fragment";dur=1064.049175,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=446.926224,nginx;desc="NGINX";dur=0.837196,glb;desc="GLB";dur=102.766131
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=A2edfD4MM%2FEYqZd4OV0Vw5wjV4ivtydPbmcf8gvYntkXrclAfTD%2FD8tBc86XVDDhOJKxvnqESXa9tyDn0Ux9xjAhiJ7fBsNFL2JhDC6%2BUJu2fJmw%2F3cvt%2BWoIvlMG3tv8iZSF0rEGwGp8eOiEeTaftW9EDWXExWsKWJs%2Bnp5e6YzQ1pP1BwEPd6ErHjivgBBzrrrWiwxgMiWn7Cn%2B7V4GsKcneFAk8TG00NGNeEFW3QyHtSYHV07fCuIfWa2YkUZJQT1ft5cHaju4OeuBkOgMA%3D%3D--OsGTDhMI%2BJm4tu%2F2--JILyBJegwP7uEYs0yIJBHA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1930353430.1753425416; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:36:56 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:36:56 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 819C:0A73:140692:166889:68832608
[PIR] Mark `ShareData` as an inplace OP and fix inplace pass by SigureMo · Pull Request #64195 · PaddlePaddle/Paddle · GitHub
[PIR] Mark
[PIR] Mark
SigureMo
changed the title
[PIR] Mark
[PIR] Mark May 14, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[PIR] Mark ShareData as an inplace OP and fix inplace pass
#64195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 10 commits into
PaddlePaddle:develop
from
cattidea:pir/mark-share-data-op-as-inplace
May 15, 2024
Merged
[PIR] Mark ShareData as an inplace OP and fix inplace pass
#64195
SigureMo
merged 10 commits into
PaddlePaddle:develop
from
cattidea:pir/mark-share-data-op-as-inplace
May 15, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
previously approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greate work!
SigureMo
changed the title
ShareData as an inplace OPShareData as an inplace OP and fix inplace pass
Aurelius84
approved these changes
May 15, 2024
zhangbo9674
reviewed
May 15, 2024
| @@ -67,6 +67,19 @@ bool CanBeDeleted(pir::Value value) { | |||
| return !(persist_attr && persist_attr.data()); | |||
| } | |||
|
|
|||
| bool HasNotUser(const pir::Value& value, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| bool HasNotUser(const pir::Value& value, | |
| bool IsLastestUser(const pir::Value& value, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个函数名字感觉含义不是很清楚，是不是换成 IsLastestUser 更明确一点
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的，下个 PR 优化下～
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的，下个 PR 优化下～
是Latest不是Lastest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是Latest不是Lastest
不说还没注意 😂，不过这里语义应该是 Last，已在 #64317 修改
zhangbo9674
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overrall
zyfncg
approved these changes
May 15, 2024
XiaoguangHu01
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
修改
ShareData为一个 inplace OP，否则 Inplace Pass 识别不到 ShareData 的写语义，导致错误地将一个 OP 转为 inplace 的，导致输入错误被更新（比如单测里的u被错误更新了）目前 Inplace Pass 处理的是有 bug 的，进而没有正确处理上面的情况，因此修改 inplace 判断策略
对于一个待替换的 OP
b来说（黄色a、c已经遍历过，绿色b正在遍历，蓝色d、f待遍历），最多可能的情况如图所示，但如果 OPd存在，那么不会在b进行 inplace，因为不是 eager deletion op我们会在遍历时维护一个
use_count_map和一个inplace_map，前者用于表示各个 Value 当前的引用计数（初始是Value.use_count()，之后会逐渐递减），只有自身 use_count 为 0 且相应的 inplace Value use_count 也为 0 的情况才能将该 OP inplacecc @HydrogenSulfate
PCard-66972