add cinn arrcuracy check #63829

chen2016013 · 2024-04-24T09:27:43Z

PR Category

Others

PR Types

Others

Description

Pcard-67164

… add_cinn_accuracy_check

… test0422

paddle-bot · 2024-04-24T09:27:47Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Aurelius84 · 2024-04-26T02:18:34Z

paddle/cinn/hlir/dialect/operator/transforms/accuracy_check_pass.cc

+
+  bool MatchAndRewrite(cinn::dialect::FusionOp fusion_op,
+                       pir::PatternRewriter& rewriter) const override {
+    auto op_list = fusion_op.GetOperators();


变量应尽量使用 const 限定符

Aurelius84 · 2024-04-26T02:19:11Z

paddle/cinn/hlir/dialect/operator/transforms/accuracy_check_pass.cc

+    auto group_info = fusion_op.attribute("group_info")
+                          .dyn_cast<cinn::dialect::GroupInfoAttribute>()
+                          .data();
+    auto fn_name = group_info.fn_name;


Suggested change

auto fn_name = group_info.fn_name;

const auto& fn_name = group_info.fn_name;

若接口和方法返回的是引用类型，应尽可能使用引用

Aurelius84 · 2024-04-26T02:21:05Z

paddle/cinn/hlir/dialect/operator/transforms/accuracy_check_pass.cc

+      if (op->isa<::pir::YieldOp>()) {
+        rewriter.SetInsertionPointAfter(fusion_op);
+        for (size_t i = 0; i < op->num_operands(); ++i) {
+          rewriter.Build<paddle::dialect::AccuracyCheckOp>(


每个if分支内部建议使用 lambda 函数单独定义，提升可读性，也可降低for-if-for的嵌套层级。

const auto& InsertAccuaryCheckOp = [&]() -> decltype(auto) {}; for (auto op : op_list) { if (op->isa<::pir::YieldOp>()) { InsertAccuaryCheckOp(); }

Aurelius84 · 2024-04-26T02:22:35Z

paddle/cinn/hlir/dialect/operator/transforms/accuracy_check_pass.cc

+
+class AccuarcyCheckPass : public pir::Pass {
+ public:
+  AccuarcyCheckPass() : pir::Pass("accuarcy_check_pass", /*opt_level=*/1) {}


建议了解下op_level不同取值的表达的意义

Aurelius84 · 2024-04-26T02:23:14Z

paddle/cinn/hlir/dialect/operator/transforms/accuracy_check_pass.h

+#include "paddle/pir/include/pass/pass.h"
+
+namespace cinn {
+namespace dialect {


Suggested change

namespace dialect {

namespace cinn::dialect::ir {

可以这样写

Aurelius84 · 2024-04-26T02:44:01Z

paddle/cinn/hlir/dialect/operator/transforms/cinn_to_pd_util.cc

+  return op_transformers[op->name()](op, builder);
+}
+
+void RewriteCinnOpToPdOp(::pir::Block* src_block, ::pir::Block* target_block) {


Suggested change

void RewriteCinnOpToPdOp(::pir::Block* src_block, ::pir::Block* target_block) {

void RewriteCinnOpToPdOp(const ::pir::Block& src_block, ::pir::Block* target_block) {

Aurelius84 · 2024-04-26T02:44:43Z

paddle/cinn/hlir/dialect/operator/transforms/cinn_to_pd_util.cc

+void RewriteCinnOpToPdOp(::pir::Block* src_block, ::pir::Block* target_block) {
+  VLOG(8) << "Rewrite CinnOp to PdOp for block.";
+  if (src_block == nullptr || target_block == nullptr) {
+    return;


ENFORCE_NOT_NULL(target_block)

Aurelius84 · 2024-04-26T02:45:56Z

paddle/phi/kernels/cpu/accuracy_check_kernel.cc

+
+  auto x_numel = x.numel();
+  for (int64_t i = 0; i < x_numel; ++i) {
+    if (!allclose(x_cpu.data<T>()[i], y_cpu.data<T>()[i])) {


VLOG 输出两个值

Aurelius84 · 2024-04-26T02:46:25Z

paddle/phi/kernels/cpu/accuracy_check_kernel.cc

+#include "paddle/phi/core/kernel_registry.h"
+#include "paddle/phi/core/tensor_utils.h"
+
+const float atol_v = 1e-5;


Suggested change

const float atol_v = 1e-5;

constexpr float kAtolValue = 1e-5;

Aurelius84 · 2024-04-26T02:47:04Z

paddle/phi/kernels/cpu/accuracy_check_kernel.cc

+                         DenseTensor* out) {
+  PADDLE_ENFORCE_EQ(x.dims(),
+                    y.dims(),
+                    phi::errors::PreconditionNotMet("input Dim must equal"));


Suggested change

phi::errors::PreconditionNotMet("input Dim must equal"));

phi::errors::PreconditionNotMet("input Dim must be equal"));

Aurelius84

LGTM

Aurelius84 · 2024-04-28T01:38:11Z

paddle/cinn/hlir/dialect/operator/transforms/cinn_to_pd_util.cc

+
+const auto& handler_reduce_max_op =
+    [&](::pir::Operation* op,
+        const ::pir::Builder& builder) -> ::pir::Operation* {


Suggested change

const ::pir::Builder& builder) -> ::pir::Operation* {

::pir::Builder& builder // NOLINT

) -> ::pir::Operation* {

Aurelius84 · 2024-04-28T01:40:05Z

paddle/cinn/hlir/dialect/operator/transforms/cinn_to_pd_util.cc

+
+}  // namespace cinn::dialect::details
+
+REGISTER_TRANSFORM_RULES(reduce_max_op,


这个宏是不是可以精简为两个参数就可以了？

* add cinn arrcuracy check * update * update date * AccuracyCheckPass * update * Refine as commented * update * update * update --------- Co-authored-by: phlrain <phliuhongyu@126.com>

phlrain and others added 6 commits April 21, 2024 22:41

add cinn arrcuracy check

7750c86

update

f4d761c

update date

2d83766

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

27b3a13

… add_cinn_accuracy_check

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

712bc56

… test0422

AccuracyCheckPass

ef9c8ba

update

3170547

chen2016013 force-pushed the test0422 branch from ec6edbd to 3170547 Compare April 25, 2024 18:06

Aurelius84 reviewed Apr 26, 2024

View reviewed changes

chen2016013 added 4 commits April 26, 2024 15:08

Refine as commented

4782cb4

update

e436a95

update

987651d

update

5d4b513

Aurelius84 approved these changes Apr 28, 2024

View reviewed changes

Aurelius84 merged commit 8a61a7a into PaddlePaddle:develop Apr 28, 2024

chen2016013 deleted the test0422 branch May 24, 2024 07:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add cinn arrcuracy check #63829

add cinn arrcuracy check #63829

Uh oh!

chen2016013 commented Apr 24, 2024

Uh oh!

paddle-bot bot commented Apr 24, 2024

Uh oh!

Aurelius84 Apr 26, 2024

Uh oh!

Aurelius84 Apr 26, 2024

Uh oh!

Aurelius84 Apr 26, 2024

Uh oh!

Aurelius84 Apr 26, 2024

Uh oh!

Aurelius84 Apr 26, 2024

Uh oh!

Aurelius84 Apr 26, 2024

Uh oh!

Aurelius84 Apr 26, 2024

Uh oh!

Aurelius84 Apr 26, 2024

Uh oh!

Aurelius84 Apr 26, 2024

Uh oh!

Aurelius84 Apr 26, 2024

Uh oh!

Aurelius84 Apr 26, 2024

Uh oh!

Aurelius84 left a comment

Uh oh!

Aurelius84 Apr 28, 2024

Uh oh!

Aurelius84 Apr 28, 2024

Uh oh!

Uh oh!

	auto fn_name = group_info.fn_name;
	const auto& fn_name = group_info.fn_name;

	void RewriteCinnOpToPdOp(::pir::Block* src_block, ::pir::Block* target_block) {
	void RewriteCinnOpToPdOp(const ::pir::Block& src_block, ::pir::Block* target_block) {

	const float atol_v = 1e-5;
	constexpr float kAtolValue = 1e-5;

	phi::errors::PreconditionNotMet("input Dim must equal"));
	phi::errors::PreconditionNotMet("input Dim must be equal"));

	const ::pir::Builder& builder) -> ::pir::Operation* {
	::pir::Builder& builder // NOLINT
	) -> ::pir::Operation* {


		} // namespace cinn::dialect::details

		REGISTER_TRANSFORM_RULES(reduce_max_op,

add cinn arrcuracy check #63829

add cinn arrcuracy check #63829

Uh oh!

Conversation

chen2016013 commented Apr 24, 2024

PR Category

PR Types

Description

Uh oh!

paddle-bot bot commented Apr 24, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Aurelius84 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!