| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 05:15:49 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=241.852415,conversation_content-fragment;desc="conversation_content fragment";dur=1040.088903,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=283.716362,nginx;desc="NGINX";dur=0.794725,glb;desc="GLB";dur=101.291745
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=Ev6QOc8WY5v%2BXYldltuZKqe4Zifv5SbkET9xQU5kDB4CS8SQW9ox6rszozaFd%2BjnYCDAIAkcsKW9y6fMi1ycFQbnLUUTN6gGEihSNHWCpfjYYXd3cyRDn4e%2BTIVCjhO6boEp3lR8zFYC0JKiTFUGtsyYKAHJfUiUs8fmIw5szKTL6zQT5iQKBWzYZz%2FzQTElmP%2Fws7FI%2FLT3Q%2FIgQZuPsQVb1IherzAeWq0VMUfOzibQEFlQ%2B1j%2FgthFnYaGJdGodwvmurs4qEUypM2G8RniWw%3D%3D--rhlSDK%2BSoCeyyux5--V%2FIw7i7yObKBV3aJ%2Bx0IYg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1572537083.1753506948; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 05:15:48 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 05:15:48 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E84A:1E56AF:1B1287:277E4B:68846484
[DCU]Fix build error on rocm5.7 by onepick · Pull Request #63738 · PaddlePaddle/Paddle · GitHub
onepick
requested review from
wanghuancoder,
Aurelius84 and
XiaoguangHu01
as code owners
May 9, 2024 08:44
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[DCU]Fix build error on rocm5.7 #63738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add rocm_path to cmake_prefix_path * rm ambiguous apt because rocm has implemented Signed-off-by: jiajuku <jiajuku12@163.com>
* change expression of Xcompiler since clang17 only support "-Xcompiler xxx" instead of "-Xcompiler=xxx" * clang17 check warning mre strictly Signed-off-by: jiajuku <jiajuku12@163.com>
Signed-off-by: jiajuku <jiajuku12@163.com>
rocm5 requires the include path: $ROCM_PATH/include Signed-off-by: jiajuku <jiajuku12@163.com>
|
你的PR提交成功，感谢你对开源项目的贡献! |
Signed-off-by: jiajuku <jiajuku12@163.com>
|
@luotao1 关于CI中没有通过的部分，都是在编译cuda的是时候，报出： 但是我本地使用nvidia/cuda:11.6.1-cudnn8-devel-ubuntu20.04镜像编译的时候，并没有报出这个错误来，请问你们的环境有什么不一样的地方吗？ |
|
@qili93 有什么更新吗？ |
qili93
reviewed
Apr 29, 2024
cmake/hip.cmake
Outdated
| @@ -68,7 +69,7 @@ find_hip_version(${HIP_PATH}/include/hip/hip_version.h) | |||
|
|
|||
| macro(find_package_and_include PACKAGE_NAME) | |||
| find_package("${PACKAGE_NAME}" REQUIRED) | |||
| include_directories("${ROCM_PATH}/${PACKAGE_NAME}/include") | |||
| # include_directories("${ROCM_PATH}/${PACKAGE_NAME}/include") | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个是要删除？可以把注释去掉
|
@onepick 当前代码的修改无法通过PR-CI-BUILD的CI，建议先修复下现有的CUDA编译问题，保障代码兼容性，谢谢！ |
看了下日志里面显示的CUDA版本是 建议可以试试看 registry.baidubce.com/paddlepaddle/paddle:latest-dev-cuda11.8-cudnn8.6-trt8.5-gcc82 的镜像本地编译看下。也辛苦 @risemeup1 确认下 https://xly.bce.baidu.com/paddlepaddle/paddle/newipipe/detail/10589314/job/26072763 这流水线使用的基础编译镜像是什么。 |
|
Sorry to inform you that 475d533's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
This reverts commit 2b3bb69.
* change build option "-Xcompiler" expression, since clang17 reuqire "-Xcompiler xxx" instead of "-Xcompiler=xxx" * remove Werror from HIP_HCC_FLAGS since clang17 check more strictly. Signed-off-by: onepick <juku.jia@hygon.cn>
|
@qili93 fail的CI部分没任何错误提示？ |
|
2024-05-02 09:52:08 **************** |
got it. @zhiqiu @luotao1 编译中的warning过多，主要是因为rocm5.7升级编译器到clang17, clang17的检测更加智能/更加严格，所以更多的warning暴露了出来 |
Signed-off-by: onepick <jiauku@hygon.cn>
onepick
requested review from
wanghuancoder,
Aurelius84 and
XiaoguangHu01
as code owners
* sign-compare * bitwise-instead-of-logical * unknown-warning-option * unused-lambda-capture * unused-variable * unused-but-set-variable * reorder-ctor * deprecated-copy-with-user-provided-copy * unused-local-typedef * missing-braces * sometimes-uninitialized Signed-off-by: onepick <jiauku@hygon.cn>
zhiqiu
approved these changes
May 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for flags.cmake
qili93
reviewed
May 11, 2024
| else() | ||
| set(SAFE_GPU_COMMON_FLAGS | ||
| "${SAFE_GPU_COMMON_FLAGS} -Xcompiler=\"${flag_name}\"") | ||
| endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里只对 WITH_ROCM 下的编译flag进行修改，不影响 GPU 编译的flag，请 @zhiqiu approve。
qili93
approved these changes
May 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
May 12, 2024
* [ROCM]Add patch for warprnnt/warpctc * add rocm_path to cmake_prefix_path * rm ambiguous apt because rocm has implemented Signed-off-by: jiajuku <jiajuku12@163.com> * [ROCM] fix build error on rocm5.7 * change expression of Xcompiler since clang17 only support "-Xcompiler xxx" instead of "-Xcompiler=xxx" * clang17 check warning mre strictly Signed-off-by: jiajuku <jiajuku12@163.com> * [ROCM] add dependent rocm lib Signed-off-by: jiajuku <jiajuku12@163.com> * [ROCM]fix build warning rocm5 requires the include path: $ROCM_PATH/include Signed-off-by: jiajuku <jiajuku12@163.com> * clean code style issue Signed-off-by: jiajuku <jiajuku12@163.com> * Revert "[ROCM] fix build error on rocm5.7" This reverts commit 2b3bb69. * [ROCm]:support rocm 57 * change build option "-Xcompiler" expression, since clang17 reuqire "-Xcompiler xxx" instead of "-Xcompiler=xxx" * remove Werror from HIP_HCC_FLAGS since clang17 check more strictly. Signed-off-by: onepick <juku.jia@hygon.cn> * Fix build error Xcompiler expression for clang17 Signed-off-by: onepick <jiauku@hygon.cn> * Fix build warning * sign-compare * bitwise-instead-of-logical * unknown-warning-option * unused-lambda-capture * unused-variable * unused-but-set-variable * reorder-ctor * deprecated-copy-with-user-provided-copy * unused-local-typedef * missing-braces * sometimes-uninitialized Signed-off-by: onepick <jiauku@hygon.cn> --------- Signed-off-by: jiajuku <jiajuku12@163.com> Signed-off-by: onepick <juku.jia@hygon.cn> Signed-off-by: onepick <jiauku@hygon.cn> Co-authored-by: onepick <juku.jia@hygon.cn> Co-authored-by: onepick <jiauku@hygon.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Others
PR Types
Bug fixes
Description
fix build error and warning on rocm5.7