| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 07:14:35 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=254.787378,conversation_content-fragment;desc="conversation_content fragment";dur=1093.297346,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=322.763486,nginx;desc="NGINX";dur=1.713211,glb;desc="GLB";dur=101.968128
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=O5NUa7ReclXE5Q8odtDiks4zUxh3Ngx2i2kpK%2Fk0uH80symGMgoSNHYMwA4uNioyTGbQoEB6f%2BLYi79N50f18UsBjl%2B3ZeEOTRaJbCaweWW0Y6MdKCRbzsCWLulLALZ%2FsbKV4v8nQJQsoDJrknTWiqPl1VFMtqio7MBEmQ4fd6QWHrvzQXsc8bd9nKtDqoNaF5KbEGgZlEt4u91eIcSCgPSG2%2BQM31mKAqsbCqPk%2Faq1UQzvN7ZgJeAwHkC45iRvqjt7hXHr1JFU6gOZ%2BfInQA%3D%3D--3cBhjzK1QA3EBFO4--wP%2FAkGmaCuF%2FuR8le0j%2FKg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2096607920.1753427673; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 07:14:33 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 07:14:33 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 96D6:10D5FF:1EBD0E:224A70:68832ED9
[CINN] Fix dynamic shape not match cause RxT cannot fuse by SigureMo · Pull Request #63658 · PaddlePaddle/Paddle · GitHub
SigureMo
changed the title
[CINN] Fix dynamic shape not match in relative judge
[CINN] Fix dynamic shape not match cause RxT cannot fuse
Apr 18, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[CINN] Fix dynamic shape not match cause RxT cannot fuse #63658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 12 commits into
PaddlePaddle:develop
from
cattidea:cinn/fix-dynamic-shape-not-match
Apr 22, 2024
Merged
[CINN] Fix dynamic shape not match cause RxT cannot fuse #63658
SigureMo
merged 12 commits into
PaddlePaddle:develop
from
cattidea:cinn/fix-dynamic-shape-not-match
Apr 22, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
changed the title
2742195759
previously approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2742195759
previously approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM，精度问题我来看吧。
tc20042008
reviewed
Apr 19, 2024
|
|
||
| namespace cinn::fusion { | ||
|
|
||
| struct ValueDim { | ||
| pir::Value v_; | ||
| size_t idx_; | ||
| ValueDim(pir::Value v, size_t idx) : v_(v), idx_(idx) {} | ||
| pir::ShapeConstraintIRAnalysis shape_analysis_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
std::weak_ptr<pir::ShapeConstraintIRAnalysis >
同时禁止ShapeConstraintIRAnalysis基类里的拷贝和移动构造函数。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
那是不是应该让 ShapeAnalysisManager::Get 返回值是 shared_ptr？这样的话改动有点多（应该有 20+ 文件），是不是在单独 PR 做一下更好一些？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已按照线下讨论使用 enable_shared_from_this
winter-wang
previously approved these changes
Apr 19, 2024
tc20042008
previously approved these changes
Apr 19, 2024
winter-wang
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
CINN
PR Types
Bug fixes
Description
修复直接通过 DenseTensor type 信息获取 shape 导致 -1 和另一个 dim 不匹配的问题，导致 R+T 没有成功 fuse，修改为使用 shape analysis 来判断 dim 是否匹配
比如这里直接通过
DenseTensortype 的 shape 获取就分别是4096和-1（cast 到size_t变成了18446744073709551615），而使用 shape analysis 则能知道它们是相同的Pcard-76996