| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 07:37:03 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=340.416061,conversation_content-fragment;desc="conversation_content fragment";dur=1108.507877,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=379.174066,nginx;desc="NGINX";dur=1.174219,glb;desc="GLB";dur=103.061321
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=cp62o0aWiP235AN6DWwjIGOtKDakz2RSSLXdmtfzZ0OG%2B0dwIm5w%2BXrL%2BKu8D%2FmsJ%2Bdypz0DiJXquhHiazii4932A86%2FfHZKGo74dXb%2FSRhrNBFO16BzzzwUGzRvziG2CUvuYFqh6xrNQbComS6Ot5WyJO61uWqAQVmdLRB3OAvaKuqIE1ltMBo54tDgOrbapJtLtLyQ5Z0hX9GsRMNlT3HKDABlIL7oh2bs13wEBGkEiU%2FjhrxIHAVl6F0vQSX6xkt%2FAUl7L6agMwVnh6xXLA%3D%3D--Hfr5nBPXXbyZBIEx--EFueqPT1FpGIH%2FXFUBcC3g%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.16917389.1753429022; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 07:37:02 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 07:37:02 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8908:0A53:12499A:1462AE:6883341E
[XPU] support flash attention for xpu when causal is false by runzhech · Pull Request #63644 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[XPU] support flash attention for xpu when causal is false #63644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
runzhech
commented
Apr 22, 2024
|
|
||
| const float* bias_data = nullptr; | ||
| if (attn_mask.get_ptr() != nullptr) { | ||
| bias_data = attn_mask->data<float>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
由于fa接口中暂不支持attn_mask，因此通过attn_mask获取数据并作为bias传入
runzhech
commented
Apr 22, 2024
| @@ -246,6 +243,10 @@ void FlashAttnKernel(const Context& ctx, | |||
| XPUType* out_data = reinterpret_cast<XPUType*>(out->data<T>()); | |||
| float* softmax_lse_data = softmax_lse->data<float>(); | |||
|
|
|||
| const float* bias_data = nullptr; | |||
| if (attn_mask.get_ptr() != nullptr) { | |||
| bias_data = attn_mask->data<float>(); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
runzhech
commented
Apr 22, 2024
| @@ -39,9 +39,6 @@ void FlashAttnGradKernel(const Context& ctx, | |||
| DenseTensor* dk, | |||
| DenseTensor* dv) { | |||
| #ifdef PADDLE_WITH_XPU_XHPC | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
目前fa已支持is_causal=false
ZibinGuo
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
XiaociZhang
reviewed
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| @@ -121,7 +121,11 @@ void FlashAttnGradKernel(const Context& ctx, | |||
| num_heads_k, // head_num_k | |||
| head_size, // head_dim | |||
| 1.0f / std::sqrt(head_size), // softmax_scale | |||
| dropout // p_dropout | |||
| dropout, // p_dropout | |||
| 0x45678901, // seed | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是否提供一种控制seed的方式？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已根据GPU的实现补上了这个功能
houj04
reviewed
Apr 23, 2024
| #include "paddle/phi/backends/xpu/enforce_xpu.h" | ||
| #include "paddle/phi/core/enforce.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个不需要吧？因为paddle/phi/backends/xpu/enforce_xpu.h里面包括了paddle/phi/core/enforce.h
houj04
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下一个版本需要做：
1、不需要的include干掉
2、增加对应的单测
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Apr 25, 2024
…dle#63644) * [XPU] support flash attention when causal=false * support generate seed from input params like gpu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Operator Mechanism
PR Types
New features
Description
support flash attention for xpu when causal is false，and enable pass bias as attn_mask