CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 06:22:08 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=266.77389,conversation_content-fragment;desc="conversation_content fragment";dur=462.909307,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=305.222986,nginx;desc="NGINX";dur=0.726596,glb;desc="GLB";dur=106.434689
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=pW7RUefF8FSej%2F0w5ns%2BYJ8cUuegoFxZCAHIt4Lh%2Bzc4JB6UrGMrgZ8Z8i6CBxCR%2FH8Lcred9cYwldAiOWDJQlSvezyxo29eZ%2F1BqEhw6PMV3clJ5O507hC2ElfhfVGOgI1IYSuKarpGdt47S7tjJ3IpQ%2FiDFrGf%2FPKZI3sctAXT8WATm1IgTTRelXBZuuXg5lx2lKZ7yLMem7gGAYT%2BD2EQxUIS22mCXSEzwmQAVls9Ygx9Hb3m95UlP6sJYdWfYnGeGFDVnrzVCe0SKd%2FDTQ%3D%3D--8CJDZ5yuyLG9tG03--9Kxe4JU442h4nrKZVCB9LA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1358793066.1753424528; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:22:08 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:22:08 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: AEBE:2026F8:33FBD7:419AE7:68832290
Lowing shape_optimization_pass to paddle/pir/ directory by chen2016013 · Pull Request #63572 · PaddlePaddle/Paddle · GitHub
chen2016013
force-pushed
the
shape_dialect
branch
from
April 16, 2024 12:44
chen2016013
changed the title
update
Lowing shape_optimization_pass to paddle/pir/ menu
Apr 16, 2024
chen2016013
changed the title
Lowing shape_optimization_pass to paddle/pir/ menu
Lowing shape_optimization_pass to paddle/pir/ directory
Apr 17, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Lowing shape_optimization_pass to paddle/pir/ directory #63572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献! |
0fad546
to
730d16f
Compare
… shape_dialect
Aurelius84
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job
zhangbo9674
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Others
PR Types
Others
Description
Pcard-67164
背景:
shape_analysis组件目前在shape_optimization_pass.cc中被隐式关联,且这个文件被显式地打入op_dialect里编译,在pir_transforms target也会编译。前者会被cinnapi.so依赖(以静态库形式),cinnapi.so又会被libpaddle.so依赖,导致libpaddle.so有两条路径会依赖shape_optimization_pass的符号:
①libpaddle.so -> ... -> libpir_transforms.a -> shape_optimization_pass
②libpaddle.so -> cinnapi.so ->op_dialect.a -> shape_optimization_pass;
这里会有全局静态变量重复初始化的问题,导致Pass被重复注册(目前会ENFORCE不允许重复注册)。后续迭代CINN很容易遇到编译问题。
解决方案:
将shape_optimization_pass组件放到paddle/pir/src/dialect/shape目录下,这样就可以放到libpir.so里编译
shape_optimization_pass调用了paddle::dialect::InferSymbolicShapeInterface类,将该interface也迁移到pir命名空间下,同时保留在paddle::dialect中的别名