CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 06:29:13 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=406.195802,conversation_content-fragment;desc="conversation_content fragment";dur=643.875956,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=341.869489,nginx;desc="NGINX";dur=1.287236,glb;desc="GLB";dur=106.449331
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=%2FdDw6W1SdEHAR9mr1Pf5y7lU4PZGVMZqAS5wtwkvHGUIpi6zygxZhGT9of9Vm0XS7rb3tX2mIysKFs1RG2kGP5DXJOOFvNfGQLEHhEGwxn3Wmf6tvuCzA0BAz8A2e5%2BMistALLlGDu2%2FNRJyveSry42Fu6kCV7RTjh%2BH2oZj4SOpqmSTjewAR9cgZUuLvSFEwU6Oq8GHpGHGAA0EoondKIDRISIth1TMDDL%2FNf4UZp7u1rB3tC1P%2BHfp68I6qx%2FMKRZl2uJqZtkuHcQm3PEcxA%3D%3D--n%2F02%2BM5cj7dVOsx5--gpuCV%2FGyj2JJGQhQ84de3w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1736565262.1753424952; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:29:12 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:29:12 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BA86:15F96:35D39C:43A9C0:68832438
refine optimizer state_dict by wanghuancoder · Pull Request #63549 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
refine optimizer state_dict #63549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wanghuancoder
merged 1 commit into
PaddlePaddle:develop
from
wanghuancoder:refine_optimizer_state_dict
Apr 16, 2024
Merged
refine optimizer state_dict #63549
wanghuancoder
merged 1 commit into
PaddlePaddle:develop
from
wanghuancoder:refine_optimizer_state_dict
Apr 16, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献! |
YuanRisheng
approved these changes
Apr 16, 2024
Asthestarsfalll
pushed a commit
to Asthestarsfalll/Paddle
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
optimizer存在如下问题:
如果用户调用了optimizer.set_state_dict(),但是没有调用optimzier.step(),此时optimizer.state_dict()返回的结果缺少set_state_dict的accumulators信息。
最早这个问题要追溯到 #20148 ,由于如果用户不调用optimzier.step(),不触发_add_accumulator,optimizer无法准确的创建self._accumulators[name][param.name]。因此,在optimizer.set_state_dict()时,将accumulators暂时存在self._accumulators_holder中,在_add_accumulator时同步到self._accumulators上。
但如果用户调用了optimizer.set_state_dict(),但是没有调用optimzier.step(),self._accumulators为空,数据仍在self._accumulators_holder上。
因此,本PR修改state_dict,如果self._accumulators为空,self._accumulators_holder有值,则将self._accumulators_holder的值给到state_dict。
Pcard-74613