CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 08:10:24 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=254.889761,conversation_content-fragment;desc="conversation_content fragment";dur=547.069256,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=324.728009,nginx;desc="NGINX";dur=0.950224,glb;desc="GLB";dur=101.113229
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=Y%2FblhgVBj1fKFK4FeiJxq7lkie7MCAI%2B%2BpDXLkThae22O6ZeDSjn9mN%2Bj9MnJWJ8K%2BfQbyW4SoQ7l1YQjgnW8b80XjCvuBdbwyNfDKo2Lfsa15Cn89RIUBOyLK0%2FctzgdkPzOtwDmUWRvG2ZQPnuljTaGP%2FesNfROEb%2F1UBZuvqYwnWChKPfiNz8rglYTqHdXp6I4Rk618DTjUcK97Y2bfxKBDV78W%2FyBBVRq8EOepNrB%2FGJwR1TWvJ71OqVaq3y1PHVMRjKRP7s8NAvheWYmA%3D%3D--Ol3Exo7W6Kg%2BxMKd--zlKPq21c95dLpyE6%2FKR7IA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1547922142.1753431024; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 08:10:24 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 08:10:24 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B8A8:0B5C:7325B:83DEC:68833BF0
[Dy2St] Mark `VariableRefArray` inner vars as no need buffer to avoid memery leak by SigureMo · Pull Request #63395 · PaddlePaddle/Paddle · GitHub
[Dy2St] Mark
[Dy2St] Mark
SigureMo
deleted the
dy2st/mark-variable-ref-array-inner-vars-as-no-need-buffer-to-avoid-memery-leak
branch
April 11, 2024 11:53
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[Dy2St] Mark VariableRefArray
inner vars as no need buffer to avoid memery leak
#63395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 5 commits into
PaddlePaddle:develop
from
cattidea:dy2st/mark-variable-ref-array-inner-vars-as-no-need-buffer-to-avoid-memery-leak
Apr 11, 2024
Merged
[Dy2St] Mark VariableRefArray
inner vars as no need buffer to avoid memery leak
#63395
SigureMo
merged 5 commits into
PaddlePaddle:develop
from
cattidea:dy2st/mark-variable-ref-array-inner-vars-as-no-need-buffer-to-avoid-memery-leak
Apr 11, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献! |
chen2016013
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
对于如下代码:
y
是一个中间变量(z
一样,不赘述),前向的concat
接收Combine(y, z)
,反向的concat_grad
同样也接收Combine(y, z)
,而concat_grad
的输入是no_need_buffer
的,也就是说前向使用完需要立即释放掉,而不是留在中间变量提供给反向我们现在已经有了对
no_need_buffer
不设置 skip gc 的逻辑,按理说其前向结束就会被 GC 掉,但这里的y
并没有被 gc 掉这是因为我们前反向拆分时对于
no_need_buffer
的分析只将concat_grad
的输入Combine(y, z)
这个VariableRefArray
标记为no_need_buffer
,却没有将其内的y
设置为no_need_buffer
,这就导致了y
在前向没有释放因此在前反向拆分时
no_need_buffer
处理逻辑中对CombineOp
内元素也进行处理Pcard-67164