| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 06:27:18 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=360.720366,conversation_content-fragment;desc="conversation_content fragment";dur=1362.95579,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=555.660028,nginx;desc="NGINX";dur=1.166534,glb;desc="GLB";dur=102.116469
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=nh4EhTjirLfAuI8ToNcpvcOAnN%2BMG65aHHT25jhbLlWWvuupeS6omPwsM225%2BMo6Fpthta785nmGEJ2CuYQiXAAGFHfpnlmd2QI6nfT03HuwVV%2F7LW%2FvgadjskucjTt7ZrBEnkiiYtJA5R8IOpai7mP3clleTI0piJgeCFWS0v17xbteIkr9NW6DkCjKH8j4dmCQNVTiiimbeuXjVM2GfTIckXOG2AvKeuoB%2FHoS844K4R0l%2Bsdub%2F7uMCzGRw04NFSZkYV53j6ivQLuYROwLA%3D%3D--hydt5HEWwbWnbwK%2F--YbYJupV0h3aj4A6WvVnaCQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1976370422.1753424836; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:27:16 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:27:16 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E7DA:1D2B8F:35B168:43782C:688323C4
[ CINN / Fusion] CINN Fusion Frontent Algorithm by 2742195759 · Pull Request #63124 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[ CINN / Fusion] CINN Fusion Frontent Algorithm #63124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Aurelius84
merged 396 commits into
PaddlePaddle:develop
from
2742195759:cinn-trivalop-fuse
Apr 6, 2024
Merged
[ CINN / Fusion] CINN Fusion Frontent Algorithm #63124
Aurelius84
merged 396 commits into
PaddlePaddle:develop
from
2742195759:cinn-trivalop-fuse
Apr 6, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aurelius84
approved these changes
Apr 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
| } | ||
| return result; | ||
| }; | ||
| VLOG(4) << "GetDimInfo"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
整体看这里的VLOG都比较短，且有一些是冗余的，建议后续可以优化下：
- 细节的VLOG level 建议开启到5或6
- 骨架逻辑的VLOG level 建议开启到4或5
- VLOG的内容准则：提供调试的必要信息
| if (op->isa<cinn::dialect::ReshapeOp>()) { | ||
| return CreateDefaultSignature(op); | ||
| } | ||
| if (op->name() == "cinn_op.generate_shape") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的if-else既有isa 又有string == ，建议统一为isa更好一些？
| @@ -174,7 +174,7 @@ def train(self, net, to_static, with_prim=False, with_cinn=False): | |||
| def test_ast_prim_cinn(self): | |||
| st_out = self.train(self.net, to_static=True) | |||
| cinn_out = self.train( | |||
| self.net, to_static=True, with_prim=True, with_cinn=True | |||
| self.net, to_static=True, with_prim=True, with_cinn=False | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里黑名单了部分单测，注意要在100子图表格里更新状态并NOTE
| @@ -679,7 +679,7 @@ def test_eval(self): | |||
| if utils.unittest_use_cinn(): | |||
| cinn_out = self.eval(use_cinn=True) | |||
| np.testing.assert_allclose( | |||
| cinn_out.numpy(), dy_out.numpy(), atol=1e-6, rtol=1e-6 | |||
| cinn_out.numpy(), dy_out.numpy(), atol=1e-5, rtol=1e-6 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里对于llama的单测精度问题的调整，也要周知相关同学看是否符合预期
| const std::vector<U>& values) { | ||
| std::unordered_map<T, U> result = std::unordered_map<T, U>(); | ||
|
|
||
| CHECK(keys.size() == values.size()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已禁止使用CHECK宏，后续要单独PR替换为PADDLE_ENFORCE_XX
tc20042008
reviewed
Apr 7, 2024
| : ops_(ops) {} | ||
| std::vector<const pir::Operation*> ops_; | ||
| std::vector<pir::Operation*> ops_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个pattern和其他pattern都没关系吗？它内部没有引用到别人，也没有被别人引用。
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Apr 9, 2024
* update * Cinn trivalop fuse (PaddlePaddle#62) * push * update * fix * fix transformer * fix * Implement iterator vars fetching in ReduceOp * small fix * add GetOuterIterVars API * fix compile complain * modify GetOutputIters of TrivialOp * remove dumplicate code in visit * implement ClusterIntoGroupPatternsFromOpList --------- Co-authored-by: feifei-111 <2364819892@qq.com> Co-authored-by: zhangbaizhou <zhangbaizhou@baidu.com> Co-authored-by: jiahy0825 <jiahongyu@baidu.com> Co-authored-by: tc20042008 <156998525+tc20042008@users.noreply.github.com> Co-authored-by: Baizhou Zhang <eddiezhang@pku.edu.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
CINN
PR Types
New features
Description
CINN Fusion Frontent Algorithm
PCard-74042