You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.
The reason will be displayed to describe this comment to others. Learn more.
@Eddie-Wang1120 Good job! 但是不推荐修改OpMaker里的内容,虽然反向算子没有兼容性问题,但是我们并不确定有没有历史代码依赖这种行为。这种命名上的问题,可以通过op_compat的机制解决,只要将旧Op里的Softmax输入映射到新Op里的out输入就行了。之所以op_compat.yaml不能解决,是因为他原本是用来解决动静Op的不一致,只涉及前向算子。所以为了翻译的时候能处理反向,在paddle/fluid/ir_adaptor/translator/op_compat_gen.py中处理下即可,添加
@Eddie-Wang1120 Good job! 但是不推荐修改OpMaker里的内容,虽然反向算子没有兼容性问题,但是我们并不确定有没有历史代码依赖这种行为。这种命名上的问题,可以通过op_compat的机制解决,只要将旧Op里的Softmax输入映射到新Op里的out输入就行了。之所以op_compat.yaml不能解决,是因为他原本是用来解决动静Op的不一致,只涉及前向算子。所以为了翻译的时候能处理反向,在paddle/fluid/ir_adaptor/translator/op_compat_gen.py中处理下即可,添加
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
改动过程:
原本为:
op->SetInput("Softmax", this->Output("Out"));
观察多个op中都为:
op->SetInput("Out", this->Output("Out"));
麻烦帮忙看一下这种修改方式是否符合规范~
PIR Op单测修复
修复单测
test_softmax_mask_fuse_op
修复后打开
FLAGS_enable_pir_in_executor
单测是否通过:是