You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the ambiguity of node execution event, the first segment is for calling GradNodeFunction, should be recognized as XXXGradNode computation cost, the second segment is for potential gradient accumulation in backward queue, should not be count into XXXGradNode, or will misleading users who profile paddle program with nsight or other visualization software.
So this PR use Local_XXXGradNode to represent execution time of XXXGradNode function, Global_XXXGradNode to represent execution time of Local_XXXGradNode plus potential gradient accumulation. Thus, Global_XXXGradNode should always be larger than Local_XXXGradNode and Local_XXXGradNode is more significant for profiling.
To achieve this target, this PR modifies eager_gen.py and several manually XXXnode.cc, and move event creation next to node execution for ignoring node(s) skipped in backward node queue(i.e.
).
before:
after:
As is dipicted below, Global_MultiplyGradNode include 2 parts: Local_MultiplyGradNode execution(grad_output_tensors = (*node)( node_input_buffer->Buffers(), create_graph, is_general_grad);) and gradient accumulation(node_input_buffers_dict[next_node]->add(edge_rank.first, edge_rank.second, grad_output_tensor, create_graph);)
你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Description
Pcard-75624
Fix the ambiguity of node execution event, the first segment is for calling GradNodeFunction, should be recognized as
XXXGradNode
computation cost, the second segment is for potential gradient accumulation in backward queue, should not be count intoXXXGradNode
, or will misleading users who profile paddle program with nsight or other visualization software.So this PR use
Local_XXXGradNode
to represent execution time ofXXXGradNode
function,Global_XXXGradNode
to represent execution time ofLocal_XXXGradNode
plus potential gradient accumulation. Thus,Global_XXXGradNode
should always be larger thanLocal_XXXGradNode
andLocal_XXXGradNode
is more significant for profiling.To achieve this target, this PR modifies

eager_gen.py
and several manuallyXXXnode.cc
, and move event creation next to node execution for ignoring node(s) skipped in backward node queue(i.e.).
before:

after:
As is dipicted below,

Global_MultiplyGradNode
include 2 parts:Local_MultiplyGradNode
execution(grad_output_tensors = (*node)( node_input_buffer->Buffers(), create_graph, is_general_grad);
) and gradient accumulation(node_input_buffers_dict[next_node]->add(edge_rank.first, edge_rank.second, grad_output_tensor, create_graph);
)