| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 03:43:26 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=274.204283,conversation_content-fragment;desc="conversation_content fragment";dur=1011.379561,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=288.713413,nginx;desc="NGINX";dur=0.872165,glb;desc="GLB";dur=102.031079
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=kWpqYURFWEF1MVFyfWaLhfSXjZtQd7Xd%2FmBDGsk7f6OxvyP9LhWrFJPqMtwQFFQIuB5fxIN%2FtBbd9I5jSNhRwujK2kU7mTKASp%2BZJ6XoCRCYAouUbr1nFtWbWqz5DCJYYicwQCzvkgvHYd%2Ff64UnQ2f8MP3%2FJuzJ0u7PHtyu%2BXXN%2BHXGbhF9BGHY89tlNsQLQfSZtPKGNfmUwp%2By8vXfCy65C5c1cThvurCC2uRQ3qdYSuCDT6y4LxmQs9RU1KjDVJvr0ui%2B7WcbnDWWZC0G1A%3D%3D--IfD04T6ajI9%2FO0Vd--2FuhyPBx8xBfMS3Ci8cABA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1426140667.1753501405; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 03:43:25 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 03:43:25 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 81E6:29FD1F:11B681:1B3391:68844EDD
[CINN] EliminateCommonGlobalVar pass, optimize performance by jiahy0825 · Pull Request #62517 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[CINN] EliminateCommonGlobalVar pass, optimize performance #62517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tc20042008
merged 5 commits into
PaddlePaddle:develop
from
jiahy0825:EliminateCommonGlobalVar
Mar 10, 2024
Merged
[CINN] EliminateCommonGlobalVar pass, optimize performance #62517
tc20042008
merged 5 commits into
PaddlePaddle:develop
from
jiahy0825:EliminateCommonGlobalVar
Mar 10, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
BiynXu
reviewed
Mar 8, 2024
| } | ||
| tensor_indices.push_back(new_indice); | ||
| } | ||
| for (const auto& [var, extent] : for_var_extents_) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个循环体中什么也不做吗？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个 for 循环应该删掉，thanks
| return AllIndiceAndExtentEqual(indice_and_extent); | ||
| }; | ||
|
|
||
| std::unordered_set<std::string> global_tensor; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
最好把global_tensor都换成global_buffer_name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done，thanks～
| }; | ||
|
|
||
| std::unordered_set<std::string> global_tensor; | ||
| for (const auto& [tensor_name, indice_and_extent] : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tensor_name -> buffer_name
不保证tensor_name和buffer_name全部一致，从代码上看，这个pass全部按buffer_name索引，包括对Load节点进行collect时，最好全部都用buffer_name。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done，thanks~
| } | ||
|
|
||
| std::unordered_set<std::string> eliminate_tensor_names_; | ||
| std::unordered_map<std::string, ir::Expr> global_tensor_to_local_tensor_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个key也是buffer_name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done，thanks~
tc20042008
approved these changes
Mar 10, 2024
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Mar 10, 2024
…dle#62517) * [CINN] EliminateCommonGlobalVar pass, optimize performance * std::cerr->VLOG * Fix trick codes * CHECK->PADDLE_ENFORCE * Fix typo
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Mar 11, 2024
…dle#62517) * [CINN] EliminateCommonGlobalVar pass, optimize performance * std::cerr->VLOG * Fix trick codes * CHECK->PADDLE_ENFORCE * Fix typo
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Mar 11, 2024
…dle#62517) * [CINN] EliminateCommonGlobalVar pass, optimize performance * std::cerr->VLOG * Fix trick codes * CHECK->PADDLE_ENFORCE * Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
Performance optimization
PR changes
Others
Description
pcard-76996
Softmax shape=[128, 12, 128, 128]场景下做性能验证phi = 248 us，CINN = 308 us，优化后 252 us，有 22.2 % 的性能提升，与 phi 基本持平
注：本 PR 的 EliminateCommonGlobalTensor pass 采取了一种较为保守的 GlobalTensor 替换策略：当且仅当同一个 GlobalTensor 在不同 ScheduleBlock 的下标索引完全相等时，才会将其替换为 LocalTensor
Perform performance validation in the
Softmax shape=[128, 12, 128, 128]scenarioPhi=248 us, CINN=308 us, optimized to 252 us, with a 22.2% performance improvement, basically on par with phi
Note: EliminateCommonGlobalTensor pass in this PR adopts a more conservative GlobalTensor replacement strategy: it will only be replaced with LocalTensor if and only if the same GlobalTensor has exactly the same index in different ScheduleBlocks