| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 06:20:07 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=285.403779,conversation_content-fragment;desc="conversation_content fragment";dur=1080.282595,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=360.289009,nginx;desc="NGINX";dur=0.829968,glb;desc="GLB";dur=100.939968
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=tBuXhiogXfsnSnSyRoPeexxlN9URFZXthx8HnQaRZoOKIYtxJQkG4%2FywKYV3eCXM4I5sPQ%2F%2F710C86ZD63QPA3VNy%2Bv4nxsDITXGVbcpMu2N6XgXLwzi8nISgMBO0NoKkxfCB7rmGR0a0F%2Bx8Ncp%2FYEgezAJEBW%2FulLukW%2FO%2Feb4whgtXpNGps85ciCmThUUzG5Ug5hAWIZ93XAt852kySISjhMivWblKbb2sWyGc46zvwSKlMFuPFC7N0SsWXcwD0QNxfVwrikc%2FG2SqVnpOA%3D%3D--aAtVJiu9eFLwCYis--Pq4Qspm6CV6rr0k90vRg1g%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1497704889.1753424406; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:20:06 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:20:06 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BF1E:15F96:3354BE:40E234:68832216
cinn(dynamic): fix reshape op when accessing shape dialect across fusion op by 6clc · Pull Request #62503 · PaddlePaddle/Paddle · GitHub
6clc
changed the title
Fix reshape dev
cinn(dynamic): fix reshape op when accessing shape dialect across fusion op
Mar 7, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
cinn(dynamic): fix reshape op when accessing shape dialect across fusion op #62503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
6clc
changed the title
BiynXu
reviewed
Mar 7, 2024
| const std::vector<Type> &out_type, | ||
| const std::vector<std::vector<ir::Dim>> &output_shapes, | ||
| const Target &target) { | ||
| framework::CINNCompute cast_compute( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generate_shape_compute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
zyfncg
reviewed
Mar 7, 2024
paddle/cinn/hlir/op/elementwise.cc
Outdated
Comment on lines
1291
to
1333
| std::shared_ptr<framework::OpStrategy> StrategyForGenerateShape( | ||
| const framework::NodeAttr &attrs, | ||
| const std::vector<ir::Tensor> &inputs, | ||
| const std::vector<Type> &out_type, | ||
| const std::vector<std::vector<int>> &output_shapes, | ||
| const Target &target) { | ||
| framework::CINNCompute cast_compute( | ||
| [=](lang::Args args, lang::RetValue *ret) { | ||
| CHECK(!args.empty()) | ||
| << "The input arguments of Cast compute is empty! Please check.\n"; | ||
| CINNValuePack pack_args = args[0]; | ||
| CHECK_GE(pack_args.size(), 1U) | ||
| << "at least 1 input tensors for Cast compute\n"; | ||
| Expr A = pack_args[0]; | ||
| CHECK(A.as_tensor()); | ||
| CHECK(!output_shapes.empty()); | ||
| auto tensor_A = A.as_tensor_ref(); | ||
| auto stages = CreateStages({tensor_A}); | ||
| VLOG(3) << "A shape: " << utils::Join(tensor_A->shape, ", ") | ||
| << ", output_shapes: " << utils::Join(output_shapes[0], ", "); | ||
| CHECK_EQ(pack_args.size(), 2U); | ||
| std::string tensor_name = pack_args[1].operator std::string(); | ||
| ir::Tensor out(ir::_Tensor_::Make(tensor_name, | ||
| tensor_A->type(), | ||
| { | ||
| Expr(1), | ||
| }, | ||
| { | ||
| Expr(1), | ||
| })); | ||
| std::vector<CINNValue> res; | ||
| stages->InsertLazily(out); | ||
| res.push_back(CINNValue(out)); | ||
| CHECK(!out_type.empty()) | ||
| << "Output type of Cast is empty! Please check.\n"; | ||
| res.push_back(CINNValue(stages)); | ||
| *ret = CINNValuePack{res}; | ||
| }); | ||
|
|
||
| auto strategy = std::make_shared<framework::OpStrategy>(); | ||
| strategy->AddImpl(cast_compute, lang::PackedFunc(), "strategy.store.x86", 1); | ||
| return strategy; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GenerateShape应该不会在静态shape场景下出现，这个接口是不没有用？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已移除
paddle/cinn/hlir/op/elementwise.cc
Outdated
Comment on lines
1690
to
1691
| .set_attr<cinn::hlir::framework::OpPatternKind>( | ||
| "OpPattern", cinn::hlir::framework::OpPatternKind::kElementWise) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以标记成no fuse类型的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Comment on lines
372
to
374
| if (op.name() == "cinn_op.generate_shape") { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
试试去掉这里可以work吗？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已移除，work
zhangbo9674
approved these changes
Mar 8, 2024
risemeup1
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM，下个PR将IR_ENFORCE换成PADDLE__ENFORCE
BiynXu
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
Others
PR changes
Others
Description
Pcard-78120
fix reshape op when accessing shape dialect across fusion op