CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 08:09:16 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=281.518196,conversation_content-fragment;desc="conversation_content fragment";dur=555.662313,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=305.725711,nginx;desc="NGINX";dur=1.246347,glb;desc="GLB";dur=101.413314
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=8jxw9Z46F2L8gfZWt0UBku8dii8jfLoDwZDeIVNsRz2VUBXYaJ4Z4EnekiJMzsEGw%2Bf23p5AVX%2B9gpEnojGIzouTWK7WegFB%2B4Tb4x%2Bnf5QVoD1AfWWRAJz1ieL9godMQlqYKJOMip%2Bj2x3zi08OcGx9VEhOgl1Ka5UsF8WKXW2p5cM56TaEfI%2F1hytXTZNqPP6W2I7KOC3UCtuJjKHIDduoEEEC0inTaVPdwlTAW25E3oWkqApoV6ctQMNbNZr7Deq4jEuP6d6xvDdEgVBV3A%3D%3D--IRFbfevdSp2EpHCP--RiJd6kdbrMHVHDirgF23Qg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.316256813.1753430955; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 08:09:15 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 08:09:15 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A60A:0A55:4602C6:518D94:68833BAB
[SOT] Always generate `false_fn` when `POP_JUMP_*` breakgraph by SigureMo · Pull Request #62424 · PaddlePaddle/Paddle · GitHub
[SOT] Always generate
[SOT] Always generate
SigureMo
changed the title
[SOT] Always generate
[SOT] Always generate Mar 5, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT] Always generate false_fn
when POP_JUMP_*
breakgraph
#62424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 4 commits into
PaddlePaddle:develop
from
cattidea:sot/always-generate-false-fn-when-breakgraph
Mar 6, 2024
Merged
[SOT] Always generate false_fn
when POP_JUMP_*
breakgraph
#62424
SigureMo
merged 4 commits into
PaddlePaddle:develop
from
cattidea:sot/always-generate-false-fn-when-breakgraph
Mar 6, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献! |
Closed
gouzil
previously approved these changes
Mar 5, 2024
false_fn
when breakgraphfalse_fn
when POP_JUMP_*
breakgraph
gouzil
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
Others
PR changes
Others
Description
Python 3.12 单测引申问题,当
POP_JUMP_*
breakgraph 时,false_fn
不存在时不可以直接gen_return
,虽然结果可能正确,但其实是未定义行为,debug 版 Python 会直接挂掉单测
jump_if_false_or_pop
3.8 原始字节码如下:
3.12 原始字节码如下:
3.8 原始字节码是
JUMP_IF_FALSE_OR_POP
,因此生成的「跳转分支」可以直接RETURN_VALUE
,因为该分支没有 pop,栈上是保留结果的,RETURN_VALUE
没问题3.12 原始字节码变成了
POP_JUMP_IF_FALSE
,跳转目标仍然是RETURN_VALUE
,但是提前COPY
将栈上变量 x2 了,这样生成的分支当然不能直接RETURN_VALUE
,仍然需要将变量 load 到栈上等操作Pcard-67164