| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 03:41:42 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=221.951285,conversation_content-fragment;desc="conversation_content fragment";dur=818.323037,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=281.868227,nginx;desc="NGINX";dur=1.065212,glb;desc="GLB";dur=101.278284
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=%2Bdq%2BOagHNeDuECrr3I6OAUAtQbP8B75HaljD80FSXaFUgmypj%2FlzbMD%2FdewsFMBzqh9FuqiJ65SNo%2FZMeNP8B71omeHOxHtsqSyeZs2GxR7LisPm%2F%2F1DzbVYnYovfP%2BPinq3mzkmxgtDgOCrEetaA0xeiw%2FZv%2BqhJItDh%2BmRZDfCQVJ5Bm5AuWpPDt8zcSka25S%2FKQRMV2ZYO16N3bchagMzH9j1AfbICmMA4jxywsCpTa%2BKv2b5g7Kt%2FfVUCOVE%2Bp1l63DLWeVZSnoHKNNwuA%3D%3D--%2BYn%2FCGQDnL0Nc%2BCG--1%2FdyoDat%2FjTRLs2TZ5bfhA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1820468441.1753501301; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 03:41:41 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 03:41:41 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 83E8:3B05D7:11A299:1B11FA:68844E75
[SOT][3.12] fix codegen out of range about generating `LOAD_ATTR` in Python 3.12 by diadestiny · Pull Request #62176 · PaddlePaddle/Paddle · GitHub
[SOT][3.12] fix codegen out of range about generating
[SOT][3.12] fix codegen out of range about generating
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT][3.12] fix codegen out of range about generating LOAD_ATTR in Python 3.12
#62176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 6 commits into
PaddlePaddle:develop
from
diadestiny:support_codegen_bytes
Feb 29, 2024
Merged
[SOT][3.12] fix codegen out of range about generating LOAD_ATTR in Python 3.12
#62176
SigureMo
merged 6 commits into
PaddlePaddle:develop
from
diadestiny:support_codegen_bytes
Feb 29, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Feb 28, 2024
Comment on lines
745
to
752
| def gen_load_attr(self, name: str, push_null=False): | ||
| if name not in self._code_options["co_names"]: | ||
| self._code_options["co_names"].append(name) | ||
| idx = self._code_options["co_names"].index(name) | ||
| if sys.version_info >= (3, 12): | ||
| idx <<= 1 | ||
| if push_null: | ||
| idx |= 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
与 LOAD_GLOBAL 不同，LOAD_ATTR 在 3.12 的最后一位用于表示 is_method，所以变量名需要修改下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Comment on lines
127
to
130
| if sys.version_info >= (3, 12): | ||
| codegen.gen_load_attr("update", True) | ||
| else: | ||
| codegen.gen_load_method("update") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不建议在这里做版本分发，可以考虑在 gen_load_method 中将 3.12+ 行为分发到 gen_load_attr(name, is_method)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
SigureMo
reviewed
Feb 29, 2024
| idx = self._code_options["co_names"].index(name) | ||
| return self.add_instr("LOAD_METHOD", arg=idx, argval=name) | ||
| if sys.version_info >= (3, 12): | ||
| self.gen_load_attr(name, True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里也加一个 return 吧，不然两个分支返回类型是不一致的
另外，加 return 的话，可以改写成 Early Return 的形式，去掉 else 及缩进
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
SigureMo
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow
gouzil
approved these changes
Feb 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
Others
PR changes
Others
Description
python 3.12中，test_21_global.py单测codegen超出范围报错：
ValueError: bytes must be in range(0, 256)，排查发现是因为side_effect文件的dict默认调用gen_load_method，对应的opcode是262 所以出错；3.12中dict.update/clear函数调用不会生成
LOAD_METHOD字节码，所以改成生成LOAD_ATTR，而dict的update/clear方法需要生成LOAD_ATTR额外push NULL；TODO: test_inplace_api.py存在类似codegen问题和
POP_JUMP_FORWARD_IF_FALSE不支持生成问题