| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 07:11:13 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=354.503788,conversation_content-fragment;desc="conversation_content fragment";dur=1282.857809,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=351.533857,nginx;desc="NGINX";dur=1.124916,glb;desc="GLB";dur=106.960902
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=DEUg4Jmy5UNCbHgJ%2B9rWUkh2HlEgWNoOntE5vB4si%2FKA%2FjIvYvyKU35X8HT8KkY9rI5I6XZyaRtoS2tQjWex7Vrko1kkCDeLHfwTYZe2EdjljXJdBRkDnfhKKN3awGOMGGX06oBBrUjPf%2BuAPy6mNq4eH8OdkUTcH8BgxHb23Txkf4MWNIyjRIfZlbqDSSK%2B86o%2BakhSIdNOD48a9%2FpOjlMRzHVnnQoxjfexrVcO%2FJc9oF145z%2FtRiRtj%2BzQYJjcTnF%2BmZz8TrbDVRBvotTG5w%3D%3D--v6TfIDf4uag1bDEf--GGDaHgtAu4TAH8vqvqsd4g%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1239163393.1753427472; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 07:11:12 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 07:11:12 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BDF4:274BD1:421820:513E71:68832E10
[Inference] Add a config api to use PIR by Sunny-bot1 · Pull Request #61968 · PaddlePaddle/Paddle · GitHub
yuanlehome
changed the title
Add a config api for PIR
[Inference] Add a config api to use PIR
Feb 29, 2024
Sunny-bot1
dismissed stale reviews from sunzhongkai588 and yuanlehome
via
March 1, 2024 05:02
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[Inference] Add a config api to use PIR #61968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
|
yuanlehome
reviewed
Feb 22, 2024
| @@ -52,6 +52,7 @@ int main(int argc, char **argv) { | |||
| config.SetModel(FLAGS_modeldir + "/custom_relu.pdmodel", | |||
| FLAGS_modeldir + "/custom_relu.pdiparams"); | |||
| config.EnableNewExecutor(true); | |||
| config.EnableUsePIR(); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
想了一下config的api名字改为EnableNewIR吧，和EnableNewExecutor一致
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
只改这个对外暴露的config的api命名即可，内部变量还是以pir***命名就行
Comment on lines
1200
to
1204
| void EnableUsePIR() { use_pir_ = true; } | ||
|
|
||
| void DisableUsePIR() { use_pir_ = false; } | ||
|
|
||
| bool pir_enabled() const { return use_pir_; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
api参考这个void EnableNewExecutor(bool x = true) { use_new_executor_ = x; }，就不需要额外DisableUsePIR了
paddle/fluid/pybind/inference_api.cc
Outdated
| @@ -794,6 +794,8 @@ void BindAnalysisConfig(py::module *m) { | |||
| &AnalysisConfig::Exp_DisableMixedPrecisionOps) | |||
| .def("exp_enable_mixed_precision_ops", | |||
| &AnalysisConfig::Exp_EnableMixedPrecisionOps) | |||
| .def("enable_use_pir", &AnalysisConfig::EnableUsePIR) | |||
| .def("disable_use_pir", &AnalysisConfig::DisableUsePIR) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disable_use_pir不需要
Comment on lines
86
to
87
| # def enable_pir(self, flag: bool): | ||
| # paddle.set_flags({'FLAGS_enable_pir_in_executor': flag}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
无用注释删掉，其他地方同
yuanlehome
reviewed
Feb 22, 2024
| @@ -369,7 +369,7 @@ AnalysisPredictor::AnalysisPredictor(const AnalysisConfig &config) | |||
| } | |||
| if (config_.new_executor_enabled()) { | |||
| config_.EnableMemoryOptim(false); | |||
| if (FLAGS_enable_pir_in_executor) { | |||
| if (config_.pir_enabled()) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
该文件这里可以删掉了
yuanlehome
previously approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yuanlehome
changed the title
sunzhongkai588
previously approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sunny-bot1
dismissed stale reviews from sunzhongkai588 and yuanlehome
via
bdab828
sunzhongkai588
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yuanlehome
approved these changes
Mar 1, 2024
qingqing01
approved these changes
Mar 1, 2024
zhangbo9674
reviewed
Mar 1, 2024
| @@ -376,7 +375,7 @@ AnalysisPredictor::AnalysisPredictor(const AnalysisConfig &config) | |||
| } | |||
| if (config_.new_executor_enabled()) { | |||
| config_.EnableMemoryOptim(false); | |||
| if (FLAGS_enable_pir_in_executor) { | |||
| if (config_.new_ir_enabled()) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| if (config_.new_ir_enabled()) { | |
| if (config_.pir_enabled()) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
New features
PR changes
APIs
Description
Pcard-71500
This PR provides an interface in Paddle Inference for users to enable the new ir.