| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 06:08:26 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=390.476516,conversation_content-fragment;desc="conversation_content fragment";dur=825.337586,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=332.210383,nginx;desc="NGINX";dur=0.989786,glb;desc="GLB";dur=100.868805
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=hbhMVggd8Q7W8uuIrZTf2veazDleX6yHIeF3bgpVDtHzidc2N9PBuXnRQ4sG4B%2FDfBC2SYk8SlmV9EVv1bzkaWiy%2BGRF08zPH%2FyBnBoFXGLAKsjo7Fyp5nqjH3dr5DIJJwGi09KM6VcCT9iYc7KTafDbj%2F4NJTBSJWyyUGP61l9Vyoh%2FAda%2FP22AnE1dxVqO%2F4%2FnV0Fhfyib1gxYPnf34bY8IQOKBTEGazqMIaEWEiqTTg27UOfBpixniUvQcGOd069IoefQegyF8JApxoiMmA%3D%3D--0mWZdHDkSXdcS4f8--W1yuVq6FZpe%2BPUUQ3Cx1ag%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1556484522.1753423705; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:08:25 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:08:25 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: AE64:9D20F:306640:3D9831:68831F59
[SOT][3.12] Fix that `frame` in eval custom code was not released in `tstate` by gouzil · Pull Request #61703 · PaddlePaddle/Paddle · GitHub
[SOT][3.12] Fix that
[SOT][3.12] Fix that
gouzil
changed the title
[sot][3.12] Fix that
[SOT][3.12] Fix that Feb 8, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT][3.12] Fix that frame in eval custom code was not released in tstate
#61703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 2 commits into
PaddlePaddle:develop
from
gouzil:eval_frame_PyEvalFrameClearAndPop
Feb 8, 2024
Merged
[SOT][3.12] Fix that frame in eval custom code was not released in tstate
#61703
SigureMo
merged 2 commits into
PaddlePaddle:develop
from
gouzil:eval_frame_PyEvalFrameClearAndPop
Feb 8, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
gouzil
changed the title
frame in eval custom code was not released in tstateframe in eval custom code was not released in tstate
SigureMo
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow
Comment on lines
+228
to
+233
| #if PY_VERSION_HEX >= 0x030c0000 | ||
| Internal_PyEvalFrameClearAndPop(tstate, frame); | ||
| #else | ||
| Internal_PyFrame_Clear(shadow); | ||
| free(shadow); | ||
| #endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
之后加一个注释吧，因为两个分支一个清理 frame，一个清理 shadow，不清楚缘由的人很容易当成 bug 的
|
记录： Python 3.11 和 3.12 的 frame 管理是不同的 Python 3.11 是自己管理， Python 3.12 则是会在
这里的差异导致了 3.11 和 3.12 分别清理了 shadow 和 frame，但其实是正确的 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
Bug fixes
PR changes
Others
Description
修复在 #61305 中遇到的问题
过不去 python debug 版本中的
framesize检查问题一：
原先使用自己
malloc创建的shadow没有对tstate进行管理，导致在RETURN_VALUE字节码中_PyEvalFrameClearAndPop的时候不能正常的清理和释放内存。解决方式：使用 cpython 自己的 Push 方式，这里用的是
_PyThreadState_PushFrame问题二：
没有对
frame在tstate进行同步_PyEvalFrameClearAndPop导致后续tstate->datastack_top异常