| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 06:15:15 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=269.914598,conversation_content-fragment;desc="conversation_content fragment";dur=852.479978,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=255.971784,nginx;desc="NGINX";dur=1.070215,glb;desc="GLB";dur=101.961132
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=t45a%2Fvj5n9n5JMQM0UDw%2Bdrmo5UupOgUM9RyRG0V1RUQrQ%2FGXUg2%2FjDA8ufKIz2f98TFv18QN2RnDbRr20S%2B%2FH0yFMX2Ov5LdIB59wJcZNdQzr97qptrR8%2B4gKFMiYovqthjdyGxBunyStVf86tgalAD7j4xqyDjV9ZpivgimQko0iaTuShFklXBX%2BsfZBF80BaFedrur980S8%2BQvZr9H2ZIsbxoOTUVwNJNI3jIIRE3SRaQJdiF7hXxDoh8tFKDKMklUD4DD%2FIOE%2FF7HJ5IPw%3D%3D--xC3VT%2BjdvM81a%2BYh--W66MJmN7G%2BmL%2FT1vHZpFuQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1592839710.1753424114; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:15:14 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:15:14 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B51A:1256D3:325DF1:3FC485:688320F2
cinn(backends): fuse last dim reduce loop and set bound of reduce thread by 6clc · Pull Request #61576 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
cinn(backends): fuse last dim reduce loop and set bound of reduce thread #61576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BiynXu
reviewed
Feb 4, 2024
| } | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
试试直接这样：
if (context_->iter_space_info.sp_space.size() < loops.size() - 1) {
loops = sch->GetLoops(block_id);
std::vector<ir::Expr> rb_loops(
loops.begin() + context_->iter_space_info.sp_space.size(),
loops.end());
sch->Fuse(rb_loops);
}
if (context_->iter_space_info.sp_space.size() > 1) {
loops = sch->GetLoops(block_id);
std::vector<ir::Expr> sp_loops(
loops.begin(),
loops.begin() + context_->iter_space_info.sp_space.size());
sch->Fuse(sp_loops);
}
tc20042008
reviewed
Feb 5, 2024
| @@ -32,11 +32,14 @@ void TileTactic::Init(ScheduleContext* context) { | |||
| } | |||
| }; | |||
| auto GetTreeReduceSize = [&](const ir::Expr& total_rb_extent) -> int64_t { | |||
| int64_t nums_thread_per_block = 1024; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不要出现幻数。这个1024怎么来的？
| } | ||
| return context_->bucket_info.rb_lower_bound; | ||
| return nums_thread_per_block > 1024 ? 1024 : nums_thread_per_block; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不要出现幻数
| @@ -67,15 +64,14 @@ void AlignIterSpaceTactic::Apply(ir::IRSchedule* sch, | |||
| if (context_->iter_space_info.sp_space.size() < loops.size() - 1) { | |||
| loops = sch->GetLoops(block_id); | |||
| std::vector<ir::Expr> rb_loops( | |||
| loops.begin() + context_->iter_space_info.sp_space.size(), | |||
| loops.end()); | |||
| loops.end() - context_->iter_space_info.rb_space.size(), loops.end()); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
对rb_loops加注释。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
既然注释里说了是reduce_loops。应该使用更多的局部变量来加强语义：
const auto& rb_loops = [&]{
const auto reduce_loops_begin = loops.end() - context_->iter_space_info.rb_space.size();
const auto reduce_loops_end = loops.end();
return std::vector<ir::Expr>{reduce_loops_begin, reduce_loops_end};
}();There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下同
tc20042008
previously approved these changes
Feb 5, 2024
tc20042008
reviewed
Feb 5, 2024
| @@ -32,11 +33,17 @@ void TileTactic::Init(ScheduleContext* context) { | |||
| } | |||
| }; | |||
| auto GetTreeReduceSize = [&](const ir::Expr& total_rb_extent) -> int64_t { | |||
| int64_t max_threads_per_sm = | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些地方一般都会习惯性的定义为const int64_t
tc20042008
reviewed
Feb 5, 2024
Comment on lines
75
to
78
| std::vector<ir::Expr> sp_loops( | ||
| loops.begin(), | ||
| loops.begin() + context_->iter_space_info.sp_space.size()); | ||
| loops.end() - context_->iter_space_info.rb_space.size()); | ||
| sch->Fuse(sp_loops); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
类似上面。我们可以使用lambda_init来加强语义：
sch->Fuse([&]{
const auto spatial_loops_begin = loops.begin();
const auto spatial_loops_end = loops.end() - context_->iter_space_info.rb_space.size();
return std::vector<ir::Expr>{spatial_loops_begin, spatial_loops_end};
}());
BiynXu
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
Others
PR changes
Others
Description
Pcard-72423