| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 05:54:54 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=231.578618,conversation_content-fragment;desc="conversation_content fragment";dur=906.81893,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=313.696189,nginx;desc="NGINX";dur=1.187768,glb;desc="GLB";dur=101.780869
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=IMeOPXX5SkK15yBHPrLgehmsTsjT6tzTQB1Yjxu%2FjzLoEfQbCmULTwLTEvZJFD%2BNBlIhvpYGbB0tj8psTAS5dxa4JJWs2JZ7AzRc1TufJV3KlEkDrAZWrJLUX0eY53kxzbrgn%2F%2BKa%2BqSVUm5pD35gXP6WPhGlWxe2hrUF8vvG8wqlgVsLmqF5XT14mFsTCBCgkXgHpdg41bP3kaaCcNSL8AO97rin9pAaDqp0jPVycMHPZn%2BjMORppT1GjKknqpHNFWwVptkgQAtFb9mbRNitw%3D%3D--PswO0xXfYB3cHcEm--CXqNJ2%2FtUoLeZ8u89BdZ8Q%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.747671282.1753422893; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 05:54:53 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 05:54:53 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 87F4:2774F0:2CA14D:3966EE:68831C2D
Move paddle enforce from phi to common by risemeup1 · Pull Request #61411 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Move paddle enforce from phi to common #61411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
risemeup1
merged 12 commits into
PaddlePaddle:develop
from
risemeup1:move_paddle_enforce_from_phi_to_common
Feb 7, 2024
Merged
Move paddle enforce from phi to common #61411
risemeup1
merged 12 commits into
PaddlePaddle:develop
from
risemeup1:move_paddle_enforce_from_phi_to_common
Feb 7, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winter-wang
previously approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greate Work!
… move_paddle_enforce_from_phi_to_common
yuanlehome
reviewed
Feb 5, 2024
| @@ -48,7 +48,8 @@ void GroupOp::Build(pir::Builder& builder, // NOLINT | |||
| std::unique_ptr<pir::Block>&& block) { | |||
| VLOG(4) << "Start build GroupOp"; | |||
| if (block && !block->empty()) { | |||
| IR_ENFORCE(block->back().isa<pir::YieldOp>()); | |||
| // IR_ENFORCE(block->back().isa<pir::YieldOp>()); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注释不需要保留了吧，下同
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的
yuanlehome
reviewed
Feb 5, 2024
| @@ -66,7 +66,145 @@ class CommonNotMetException : public std::exception { | |||
| }; | |||
|
|
|||
| namespace enforce { | |||
| namespace details { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
秉持着一个原则就是能放到.cc中实现的，就放在.cc中。具体就不细看了～
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯嗯
zhangbo9674
previously approved these changes
Feb 5, 2024
paddle/phi/core/enforce.cc
Outdated
| } | ||
| return sout.str(); | ||
| } | ||
| // TEST_API std::string SimplifyErrorTypeFormat(const std::string& str) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete？
| @@ -143,7 +144,11 @@ void ConcatOp::Build(pir::Builder& builder, // NOLINT | |||
| argument.inputs = inputs; | |||
| std::vector<pir::Type> inputs_type(inputs.size()); | |||
|
|
|||
| IR_ENFORCE(inputs.size() > 0); | |||
| // IR_ENFORCE(inputs.size() > 0); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete unused code
| // IR_ENFORCE(attributes.count(kAttrName) > 0 && | ||
| // attributes.at(kAttrName) | ||
| // .isa<cinn::dialect::CINNKernelInfoAttribute>(), | ||
| // "Type of attribute: instruction is not right."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
… move_paddle_enforce_from_phi_to_common
Galaxy1458
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
Others
PR changes
Others
Description
将paddle/phi目录下的paddle_enforce*系列下沉到common
Pcard-67164