CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
change_flags #60860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change_flags #60860
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
❌ The PR is not created using PR's template. You can refer to this Demo. |
…nto change_flags
…nto change_flags
CMakeLists.txt
Outdated
@@ -62,7 +62,7 @@ option(WITH_IPU "Compile PaddlePaddle with Graphcore IPU" OFF) | |||
option(WITH_ONNXRUNTIME "Compile PaddlePaddle with ONNXRUNTIME" OFF) | |||
option(WITH_CUSPARSELT "Compile PaddlePaddle with CUSPARSELT" OFF) | |||
option(WITH_SETUP_INSTALL "Compile PaddlePaddle with setup.py" OFF) | |||
option(WITH_SHARED_PHI "Compile PaddlePaddle with SHARED LIB of PHI" ON) | |||
option(WIPHITH_SHARED_ "Compile PaddlePaddle with SHARED LIB of PHI" ON) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
option(WIPHITH_SHARED_ "Compile PaddlePaddle with SHARED LIB of PHI" ON) | |
option(WITH_SHARED_PHI "Compile PaddlePaddle with SHARED LIB of PHI" ON) |
@@ -0,0 +1,1580 @@ | |||
// Copyright (c) 2019 PaddlePaddle Authors. All Rights Reserved. | |||
// Copyright (c) 2022 NVIDIA Authors. All Rights Reserved. | |||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里是不是要改成2024?
@@ -0,0 +1,41 @@ | |||
// Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved. | |||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2024?
paddle_inference_shared common) | ||
inference_base_test(test_benchmark SRCS benchmark_tester.cc DEPS | ||
paddle_inference_shared common) | ||
inference_base_test(test_table_printer SRCS table_printer_tester.cc DEPS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
删掉
if isinstance(x, (Variable, Value)): | ||
return paddle.full(shape=[], fill_value=value, dtype="bool") | ||
else: | ||
return value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
拉一下最新代码
SRCS flags_native_test.cc | ||
DEPS paddle_flags) | ||
endif() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以注释掉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以注释掉
@risemeup1 @Galaxy1458 请问一下这里为什么需要注释掉,我这边在做paddle_test 推全,rebase origin/develop后发现这里被注释了,请问还需要我同步修改吗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
单测删除
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
Others
Description
将flags体系下沉至common库,这样,common、pir、phi、cinn、fluid都可以直接使用paddle_enforce即可
TODO:
1.fix codestyle
2.add flags test
card-67007