| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 06:22:19 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=207.701415,conversation_content-fragment;desc="conversation_content fragment";dur=488.18461,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=258.222865,nginx;desc="NGINX";dur=0.993388,glb;desc="GLB";dur=105.461429
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=sWMT16oeZ69sHL3nLanmU8MY9MJ0OxSbSs8acUkT2OLpUQD0Iiza6iSg8i%2F0xREHE3D8Y%2BrYcqDfjugtMUyQ0jx2dg8HKcdSmvKyadtXAypQaq64yp6GAQhbujigqfWW8UboLDjdgr0uP8q8Oh0tkldYRLA0PM5z3mR53pVCLc7MZBfZ1aWQR7MkwfOVjOXdBcqqDHOOrW3FEUZTWsqS1mi8iWxZJqm3jAzybTZ%2F0kyfmpJJ%2BzLhfz9%2BFDJwanvIJtjThVQMgk%2F4X2n2bj7Pqg%3D%3D--Qb8tyb01SddfiV29--ZCzTYoTGy1%2ByPPUPoXMsDA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.41774475.1753424539; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:22:19 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:22:19 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8B4E:2B2ABB:344752:41E7EE:6883229B
Fix custom OP bug for AMP by From00 · Pull Request #60052 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Fix custom OP bug for AMP #60052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
From00
merged 1 commit into
PaddlePaddle:develop
from
From00:fix-custom-op-bug-for-amp-auto-cast
Dec 18, 2023
Merged
Fix custom OP bug for AMP #60052
From00
merged 1 commit into
PaddlePaddle:develop
from
From00:fix-custom-op-bug-for-amp-auto-cast
Dec 18, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Xreki
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
HermitSun
pushed a commit
to HermitSun/Paddle
that referenced
this pull request
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
Bug fixes
PR changes
Others
Description
AMP策略存在从算子注册信息中检查该算子是否实际支持低精度类型的逻辑，若检测算子不支持低精度，即使该算子被用户指定到AMP白名单中，也不为该算子做cast。
这个机制对自定义算子是失效的。自定义算子注册的kernel dtype类型是RAW (runtime decided type)，框架中无法感知自定义算子实际支持的数据类型。即使自定义算子支持低精度运算，在当前逻辑下也会被认为不支持低精度运算，这导致当前llama模型中使用的fused_rms_norm自定义算子在静态图下无法运行低精度运算（由于动态图下AMP策略运行时尚未触发自定义算子注册逻辑，因此未触发检查拦截）。
本PR对AMP相关逻辑进行修改和适配，名单控制针对自定义算子放松约束，跳过相关dtype检查，交给用户自己来管理。对于自定义算子，如果用户添加了AMP白名单，就直接按用户指定的来，不会再检查该算子是否实际支持AMP，而由用户自己做好相关保证。
Pcard-76459