| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 06:56:02 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=365.09977,conversation_content-fragment;desc="conversation_content fragment";dur=703.665037,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=357.82375,nginx;desc="NGINX";dur=1.043641,glb;desc="GLB";dur=101.663641
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=mWdqpaco%2Bg%2FVB4iA5wk05KGzWZhfOO3L8IWfHOeLsQ15%2Bwz6vKqS%2BtmaJ892vioyB%2BC9TonktOH6t%2FXQclnQ0GksPZ6iJIJ%2FwoLur94Jx6NoPWnbKiYlLOSkAhxI7PztqzcD57ZiSSzBAtSxlzi2H4w6SCmn4i7pgaiTGCXGq9fKynf%2BQ%2BqKr6dFEhJAF5nOzUrUPlQa6f58enZoBsMiUQohGBE3GukNc0IXib34gPfHtMDCDOOFZ5QYe9hvfXQdzOF%2B2Uz6CQR%2BK%2BqvXUvcrw%3D%3D--f30j7S3HHM0ETiQF--MW64x29EOTDAfFDUhSvPag%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1317843624.1753426561; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:56:01 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:56:01 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E02A:3FCB1:3D7451:4C2215:68832A81
【pir】add test_while_api.py gradient case by xiaoguoguo626807 · Pull Request #59999 · PaddlePaddle/Paddle · GitHub
xiaoguoguo626807
changed the title
【pir】add stopgrdient for output of While op
【pir】add test_while_api.py gradient case
Dec 18, 2023
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
【pir】add test_while_api.py gradient case #59999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
xiaoguoguo626807
merged 17 commits into
PaddlePaddle:develop
from
xiaoguoguo626807:while
Dec 19, 2023
Merged
【pir】add test_while_api.py gradient case #59999
xiaoguoguo626807
merged 17 commits into
PaddlePaddle:develop
from
xiaoguoguo626807:while
Dec 19, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
xiaoguoguo626807
changed the title
changeyoung98
previously approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
changeyoung98
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
HermitSun
pushed a commit
to HermitSun/Paddle
that referenced
this pull request
Dec 21, 2023
* optimize backward * [PIR] add vjp interface for while op * [PIR] fix ci error. * modify while stopgradient * merge * modify while grad bug * modify while grad op * modify * code style * code style --------- Co-authored-by: winter-wang <1030748926@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
New features
PR changes
others
Description
pcard-67164
改动点：
1.增加while op 对输出的stopgradient 设置， 处理while 对cond 的stopgradient =True 检查报错
2.backward 在while Op 下yield 的变量和op 输入个数不一致，需要跳过new_cond
3.no_grad_set 未处理子block中的value,导致call_vjp的input_stop_gradeint 创建错误
4.no_grad_set 的推导，起始inputs_ser 应该包含全部input,缺少all_used_ops的接口，会导致while op被剪枝
5.block_arument命中inpu.get_defining_op=none，导致stop_gradient都被标记为true.
6.argument 和while输入应该 共享梯度记录，需要map绑定关系. 最后需要将while 输出的梯度和输入的梯度进行add操作
7.push op 的call_vjp 应该与stop_gradient 无关。返回的变量是前向变量的复制值，如果返回为None 会导致control_flow_map 无效