| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 06:30:56 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=269.332181,conversation_content-fragment;desc="conversation_content fragment";dur=1384.115898,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=383.750837,nginx;desc="NGINX";dur=1.107084,glb;desc="GLB";dur=102.53507
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=idUoqZYaRHTJzWwEO%2BgUamm%2Fj%2Bx8szRFMuW3X4noR2cbUPdahIl%2Bl0Ba%2Bn9iD%2FDobVXLVoZxOi%2Fa27SIs80cmaU1PuyNAa6c%2FbWLvyuBVoLWlR3GPkl4q4rhxEB61K3lWSPevnDD%2Bvqj0i%2FhtFY9R%2ByhC8gyrcWgVB1%2B0E%2FF9DlNImpCc0JqTUfidtKmRB3ObNlKjzn03sZ45XiMv3UUXy97Jb5HuITebI%2F9wnf8eF8%2BvsHV%2FJ7SENdF8JdFvFRdyvEijUjrJH33kNWQJtENmw%3D%3D--3E1oUOOztZFZQof4--WUM%2FtgpPW8IdBangEV09lg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.17086880.1753425054; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:30:54 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:30:54 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B570:10D5FF:126F60:14A090:6883249E
Support pir for python get set by zoooo0820 · Pull Request #59928 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Support pir for python get set #59928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jeff41404
merged 11 commits into
PaddlePaddle:develop
from
zoooo0820:support_pir_for_python_get_set
Dec 20, 2023
Merged
Support pir for python get set #59928
jeff41404
merged 11 commits into
PaddlePaddle:develop
from
zoooo0820:support_pir_for_python_get_set
Dec 20, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Dec 14, 2023
| @@ -244,6 +278,7 @@ def foo(x, H, W): | |||
| pad_list[1] = W // 2 | |||
|
|
|||
| x = F.pad(x, pad_list, data_format="NHWC") | |||
| breakpoint() | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里忘删了
SigureMo
previously approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow
0x45f
previously approved these changes
Dec 19, 2023
zhangbo9674
reviewed
Dec 19, 2023
| orig_name, | ||
| phi::errors::PreconditionNotMet( | ||
| "SetParamer param name should not equal with var name")); | ||
| if (param_name == orig_name) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
什么场景下会出现param_name == orig_name的情况？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Program中有两条set parameter 语句：
setparameter value1 output1
setparameter value1 output1
就会触发这个检查。
就是对同一个 value，进行了两次set parameter，他们的名字相同。
zhangbo9674
approved these changes
Dec 20, 2023
0x45f
approved these changes
Dec 20, 2023
SigureMo
reviewed
Dec 20, 2023
| self.father[father_x] = father_y | ||
|
|
||
| def find_root(self, x): | ||
| if not self.father.__contains__(x): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里应该直接用原来的 in 也没关系吧，self.father 已经是 ValueDict 了，重写了 __contains__，应该已经是安全的， @0x45f 觉得呢？
只是写法问题，本 PR 不改也没关系
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里我理解原来的写法也是可以的，但是目前的写法也没有问题~
| @@ -80,7 +81,7 @@ def get(self, program, value): | |||
| return None | |||
| root_var = inplace_dict[value] | |||
| saved = [] | |||
| while root_var in inplace_dict.keys(): | |||
| while inplace_dict.__contains__(root_var): | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里原来的写法需要修改为root_var in inplace_dict，需要去掉keys()，因为原来的写法相当于是 x in list这种用法，是禁止的~
SigureMo
approved these changes
Dec 20, 2023
jeff41404
approved these changes
Dec 20, 2023
HermitSun
pushed a commit
to HermitSun/Paddle
that referenced
this pull request
Dec 21, 2023
* support __getitem__ & __setitem__ in PIR * dy2static consider inplace mapping. * fix DtypeError in case15 * disable AST+PIR only * add missing decorator test_legacy_and_pt_and_pir * modify Py_Dict to ValueDict * fix test_top_p --------- Co-authored-by: xiongkun <xiongkun03@baidu.com> Co-authored-by: SigureMo <sigure.qaq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
New features
PR changes
Others
Description
Pcard-66985
support
__getitem__and__setitem__in PIR