| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 06:29:57 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=274.103162,conversation_content-fragment;desc="conversation_content fragment";dur=569.016385,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=287.204866,nginx;desc="NGINX";dur=0.95299,glb;desc="GLB";dur=102.27201
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=MG5HPEWr5FeNj8%2FPlfW8i2NY3ORqzhuzhX0uprdNE%2FqchhgbUeTzuHd1Wfn6AsKeoEr8ED4SF0zu8urBuEyEDcgL2gcB2CFSov7fYqKgxQPTQhWMPn%2BjbNgik4pMjMC9la4aFnQdZAWM1XJZT%2FesXDZ09X66MGLLMnRrufSrUUOgQ6bULae7TCcq7B%2BhRPTRdqiyAjqgKYYE4Pl3fXYcETaRVw%2BeCroIqLrUHRI4ZJTafT4Sp8twXihKH4B4l00dikJ525GP5mjI1Y5bT42rqA%3D%3D--eAh0I4kaxymyt6%2Fm--hAJO0XQ6OmvTszqRNscq1g%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.743739626.1753424996; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:29:56 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 06:29:56 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9FC4:1D2B8F:367399:444F9B:68832464
[PIR] fix the insertion point error when create parameter in subblock. by winter-wang · Pull Request #59858 · PaddlePaddle/Paddle · GitHub
winter-wang
force-pushed
the
cf_develop
branch
2 times, most recently
from
December 10, 2023 02:21
winter-wang
force-pushed
the
cf_develop
branch
from
December 10, 2023 05:51
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[PIR] fix the insertion point error when create parameter in subblock. #59858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
winter-wang
force-pushed
the
cf_develop
branch
2 times, most recently
from
a6e6127 to
1cfc10d
Compare
winter-wang
force-pushed
the
cf_develop
branch
from
1cfc10d to
d600df1
Compare
xiaoguoguo626807
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
YuanRisheng
approved these changes
Dec 11, 2023
| insertion_point_stack_.push(builder_->insertion_point()); | ||
| } | ||
| // pop the insertion point and set it to the current insertion point. | ||
| void LoadInsertionPoint(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个为啥改名为Load了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
因为把以前的Push接口拆分为了Push+Set两个接口。相应的，Pop的接口应该跟Push相对应，只Pop,不Set。 这儿借鉴了OpenGL的接口命名， Load = Pop + Set。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
Bug fixes
PR changes
Others
Description
之前的ProgramGuard在切换到一个新的Program的时候，会同步设置插入点到新Program的主block的尾部，并保存旧的Porgram。当ProgramGuard结束的时候，会切换回旧的Porgram，并将插入点设置到旧Porgram的主block的尾部。
在本pr中，ProgramGuard在切换到一个新的Program的时候，不仅保存旧的Porgram，还会保存旧的插入点。当ProgramGuard结束，在切换回旧的Porgram时，不会将插入点设置到旧Porgram的主block的尾部，而是将插入点恢复到切换之前的位置。
Other
Pcard-67164