| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 03:43:32 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=317.563408,conversation_content-fragment;desc="conversation_content fragment";dur=1050.619825,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=395.931457,nginx;desc="NGINX";dur=0.725173,glb;desc="GLB";dur=101.070106
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=ci8EfzoqtEWwjmmwykwsJX%2F6Tph9Vy%2FeWntcKhoCd55jNzFISbCx%2BMauwP80DIzsOfsZ3mQb0LibKU3YYC1Aa5eKCLNYCSBEQxIu8k5ryC21sz5JCyYdrirpfA4VWZ4AkXM611MGa0KCOq9AmK52lI7PXPwVhZs2lop95BInuPTuIeBGFJEb1DX2Oddk1CSHju4irOQ1WqbFcCWwREkHbbwpzO180CxSAkvbOYAHAOpc1hxlGicmY1x5gsm29ef1fGSn2IumZfXhx4WWqQ4bRg%3D%3D--fCXZLHvrHBnwex6V--28a1TY7EMwmahVV64iedYg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1531373216.1753501411; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 03:43:31 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 03:43:31 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CFE0:2F5ED7:11F630:1B756B:68844EE3
【Complex op】add complex support for assign_value by zyt1024 · Pull Request #59536 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
【Complex op】add complex support for assign_value #59536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
luotao1
merged 14 commits into
PaddlePaddle:develop
from
zyt1024:support_complex_assign_value
Dec 28, 2023
Merged
【Complex op】add complex support for assign_value #59536
luotao1
merged 14 commits into
PaddlePaddle:develop
from
zyt1024:support_complex_assign_value
Dec 28, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
…ort_complex_assign_value
…ort_complex_assign_value
…ort_complex_assign_value
…ort_complex_assign_value
GGBond8488
reviewed
Dec 26, 2023
| @@ -46,6 +46,10 @@ std::pair<bool, std::unordered_map<std::string, uint32_t>> DetectLegacyOps( | |||
| paddle::framework::compatible::get_op_version_map()) { | |||
| current_op_versions.insert( | |||
| std::make_pair(pair.first, pair.second.version_id())); | |||
| if (pair.first == "assign_value") { | |||
| VLOG(6) << "get_op_version_map----------------------------------" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个日志格式不规范
| @@ -232,6 +316,13 @@ void ConvertProgram(ProgramDesc* program) { | |||
| for (size_t j = 0; j < num_ops; j++) { | |||
| OpDesc* op = block->Op(static_cast<int>(j)); | |||
| const std::string op_type = op->Type(); | |||
| if (op_type == "assign_value") { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里legacy_op_versions 问题看起来是绕过去的，并不是合理的解决问题的办法
| return new Complex64AttributeStorage(key); | ||
| } | ||
| static std::size_t HashValue(const ParamKey &key) { | ||
| return std::hash<float>{}(key.real + key.imag); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个问题还是没有解决，这个仍然会碰撞,完全可以把复数先转换成字符串（1.0+2.0j -> "1.0 + 2.0j"），再取hash
| return new Complex128AttributeStorage(key); | ||
| } | ||
| static std::size_t HashValue(const ParamKey &key) { | ||
| return std::hash<double>{}(key.real + key.imag); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
GGBond8488
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jeff41404
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vivienfanghuagood
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for api change
Wanglongzhi2001
pushed a commit
to Wanglongzhi2001/Paddle
that referenced
this pull request
Jan 7, 2024
* support_complex_for_assign_value * add test complex test for test_program_converter * add complex test for assign_value xpu * solve conflict * fix timeout * fix CE infer bug * fix program convert bug * fix program convert bug for assign_value --------- Co-authored-by: zyt1024 <1522064645@qq.com>
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
New features
PR changes
OPs
Description
add complex support for assign value