| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 21:47:22 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=357.731018,conversation_content-fragment;desc="conversation_content fragment";dur=1145.064318,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=387.580655,nginx;desc="NGINX";dur=1.500249,glb;desc="GLB";dur=101.976348
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=3D6VdL%2B161gcOOqvwuz4S4uqVO7bemnsvtYl2a332Kl7%2FGITCPkeE5TZSCgyjZveCo%2BYpytaTrgD3aWwfr2dj1OiKGB2tQuOkGon9RqBTN5PLc5UsqHs0QtTwWJwjKt%2BMAf1%2BtYMF6q1tyVE5V99RDK34lcvYOpAdXVlbyCbF9PKPtiiMcihJDvHXoU0mKTYXWeNqL%2FSmRD6hckZrPWnUQPacfDeyMEumpRVvWuVlK44a4xZjnb3Q9eYNPGYGtTqs0ClRWiAUaqcChpBHDAxhw%3D%3D--QCgiAP55CTPKT6JJ--UiS2EU29C8jKAX3%2FDPTSjA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1396423162.1753307241; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:47:21 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:47:21 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BA08:12BD61:10F2F0C:143CFFE:68815869
[OneDNN] Replace cpu.h header in default OneDNN to deploy by zhanglirong1999 · Pull Request #59259 · PaddlePaddle/Paddle · GitHub
zhanglirong1999
force-pushed
the
oneDNN_default_cpu_header_fix
branch
2 times, most recently
from
November 22, 2023 22:19
zhanglirong1999
force-pushed
the
oneDNN_default_cpu_header_fix
branch
from
November 23, 2023 03:34
zhanglirong1999
force-pushed
the
oneDNN_default_cpu_header_fix
branch
4 times, most recently
from
November 23, 2023 06:22
zhanglirong1999
force-pushed
the
oneDNN_default_cpu_header_fix
branch
from
November 23, 2023 08:41
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[OneDNN] Replace cpu.h header in default OneDNN to deploy #59259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yuanlehome
merged 9 commits into
PaddlePaddle:develop
from
zhanglirong1999:oneDNN_default_cpu_header_fix
Nov 23, 2023
Merged
[OneDNN] Replace cpu.h header in default OneDNN to deploy #59259
yuanlehome
merged 9 commits into
PaddlePaddle:develop
from
zhanglirong1999:oneDNN_default_cpu_header_fix
Nov 23, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhanglirong1999
force-pushed
the
oneDNN_default_cpu_header_fix
branch
2 times, most recently
from
4b98eec to
6f22ecc
Compare
|
@xinyu-intel @vivienfanghuagood , please help review, thanks~ |
xinyu-intel
previously approved these changes
Nov 23, 2023
vivienfanghuagood
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
您好，我有一些建议：
|
|
或者您可以在Predictor的构造函数里（paddle/fluid/inference/api/analysis_predictor.cc），当满足条件时，调用config.EnableMKLDNN(); |
|
@yuanlehome ，好的，多谢解答，感觉第二种思路会更好一些 |
zhanglirong1999
force-pushed
the
oneDNN_default_cpu_header_fix
branch
from
6f22ecc to
6373091
Compare
yuanlehome
reviewed
Nov 23, 2023
zhanglirong1999
force-pushed
the
oneDNN_default_cpu_header_fix
branch
4 times, most recently
from
40bc60e to
535ba48
Compare
|
@yuanlehome 能否帮忙看下这样是否合理，这样就不需要对每一个config的构造函数赋值了 |
恩 我认为是合理的～ |
zhanglirong1999
force-pushed
the
oneDNN_default_cpu_header_fix
branch
from
535ba48 to
ee27949
Compare
yuanlehome
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
…le#59259) * Fix cpu.h header can not package in deploy * run CI * Add win32 header * enable mkldnn in predictor not in config * delete useless code * change logic to filter avx * fix * make use_mkldnn_ = false * exchange position to coverage CI pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
Bug fixes
PR changes
Others
Description
cpu.h header in default OneDNN will have error in deploy causing by this header files cannot be exposed to the outside world and packaged.