| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 01:11:58 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=378.360743,conversation_content-fragment;desc="conversation_content fragment";dur=1042.512863,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=387.228101,nginx;desc="NGINX";dur=0.688414,glb;desc="GLB";dur=100.778406
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=RqmobVe9JhmoAd71FuN8m8950BA9l5K9H%2Fl2SjAVEnYalTbbAgcwGr%2BcfixSowXllKyKzSrhhu1vLBGK%2BkXbyaKKCRnWNCA%2BfDEutWe%2Fk%2FGn9zvuzkyDjZaeRVenvRQhE9PsSi%2FHEhnVOw7NdarQTu45EAEYYY3o35kHxAvOdBaQwzUfedDVQ%2B4koo53ExioswR%2BGPmpo72XeZZKhnrAOyS3L1cgO%2FASqsmk5bTJMkuXAl5dTKNVDH5tHKxRAX0X9a3kE%2B6a4aDuzznR%2F%2BvYcg%3D%3D--k6GfvKbe%2B2byoYAe--AiK08dNLdnan2nxhCfbaQQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.847806697.1753405917; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 01:11:57 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 01:11:57 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9A6E:2D5B28:6CEDC:A9C4B:6882D9DD
[PIR+CINN]Refactor CINNGroupLoweringPass into ::pir::Pass by Aurelius84 · Pull Request #59170 · PaddlePaddle/Paddle · GitHub
Aurelius84
force-pushed
the
migrate_cinn_pass
branch
from
November 21, 2023 02:06
Aurelius84
force-pushed
the
migrate_cinn_pass
branch
from
November 21, 2023 04:57
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[PIR+CINN]Refactor CINNGroupLoweringPass into ::pir::Pass #59170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Aurelius84
merged 3 commits into
PaddlePaddle:develop
from
Aurelius84:migrate_cinn_pass
Nov 22, 2023
Merged
[PIR+CINN]Refactor CINNGroupLoweringPass into ::pir::Pass #59170
Aurelius84
merged 3 commits into
PaddlePaddle:develop
from
Aurelius84:migrate_cinn_pass
Nov 22, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
force-pushed
the
migrate_cinn_pass
branch
from
496dcde to
de1a712
Compare
fix UT fix headers fix headers
Aurelius84
force-pushed
the
migrate_cinn_pass
branch
from
8202b02 to
8b0bae1
Compare
Aurelius84
commented
Nov 21, 2023
| VLOG(4) << "Before GroupOpPattern: " << *program; | ||
| // TODO(Aurelius84): Remove scope after cleaning PirCompiler usless Build | ||
| // Interface | ||
| auto scope = std::make_shared<cinn::hlir::framework::Scope>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里会单独提一个PR，清理掉PirCompiler里无用的Build函数，并解除构造函数对Scope的依赖
zyfncg
reviewed
Nov 21, 2023
Comment on lines
+179
to
+180
| if (value_map.find(vec_ins[i]) != value_map.end()) { | ||
| vec_ins[i] = value_map.at(vec_ins[i]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个value_map的作用是什么？感觉好像可以去掉？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里是为了处理，一个group op内的op被op fusion& fusion merge 拆成多个group时，这些小的group 之间的输入、输出传递，下一个jit kernel op 需要通过这个map ，找到对应的输入信息
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里不能去掉value_map，他是为了给cinn_jit_kernel 关联新的value的，这个「关联」在MatchRewrite机制是cover不了的。典型的场景是：一个GroupOp，可能会在lowering层拆出多个group，每个group都会对应一个cinn_jit_kernel，但他们之间的输入输出关联不是顶层Program下的op的，而是GroupOp里内在block的，因此需要这个value_map来映射
tianshuo78520a
approved these changes
Nov 22, 2023
zyfncg
approved these changes
Nov 22, 2023
phlrain
approved these changes
Nov 22, 2023
XiaoguangHu01
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chenwhql
approved these changes
Nov 22, 2023
lanxianghit
approved these changes
Nov 22, 2023
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
…le#59170) * [PIR+CINN]Refactor CINNGroupLoweringPass into ::pir::Pass fix UT fix headers fix headers * fix typo * fix UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
Function optimization
PR changes
Others
Description
Pcard-67164
由于 cinn_group_fusion Pass 依赖的逻辑和文件比较多，为了目录更有条理，故单独把其依赖的内容放到了 group_merge 目录下。
重构之后，apply_pir_pass 函数可以变成 void 返回，变为了对Program原位的修改，提升易用性