CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 21:48:09 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=270.707746,conversation_content-fragment;desc="conversation_content fragment";dur=496.895806,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=270.960122,nginx;desc="NGINX";dur=1.348154,glb;desc="GLB";dur=101.104207
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=IY9x4RM8QmrvRHKVPSKIvWyKrM4MsnSR%2ByPp6kG6%2BxD7Olh2%2FhucWS0g2OmIwH8HsX%2BghhBJ64GKQhg7zXPSbzDxVHdDjMGqRFr6fYruWkZGte2pyE0QvWM7jAzcK%2BNILuDtRz7ZuYiacgx2Ik6qgDjyCoIXxP27N6WGzSVUGlAlvmZKKnPD4SfijTL%2FHkqUtQygKc5BoxSEmy9vb%2FDaLpnRaNZabTkhD7zsJTkKK4RMx%2FvDptEN8ludzbHqRBJNjTyEubtvsmNNDjcaxSqCfA%3D%3D--oB6WmK1q92Ws3cby--VNHYjh6xE0kBjLci987AvA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.999083651.1753307289; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:48:09 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:48:09 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C674:3644F0:10EB99D:1435D6B:68815899
[CodeStyle] Use PFCCLab forked cmake-lint hook by SigureMo · Pull Request #59072 · PaddlePaddle/Paddle · GitHub
SigureMo
changed the title
[CodeStyle] Use PFCC forked cmake-lint hook
[CodeStyle] Use PFCCLab forked cmake-lint hook
Nov 16, 2023
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[CodeStyle] Use PFCCLab forked cmake-lint hook #59072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 2 commits into
PaddlePaddle:develop
from
cattidea:codestyle/use-forked-cmakelint
Nov 17, 2023
Merged
[CodeStyle] Use PFCCLab forked cmake-lint hook #59072
SigureMo
merged 2 commits into
PaddlePaddle:develop
from
cattidea:codestyle/use-forked-cmakelint
Nov 17, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献! |
luotao1
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
Others
PR changes
Others
Description
我们现在使用的 https://github.com/cmake-lint/cmake-lint 已经是一个 fork 后继续维护的项目了,但是新的维护者已经 9 个月没有任何更新且不响应任何 issue、PR,最近发布的 Python 3.12 已经无法运行 cmake-lint( cmake-lint/cmake-lint#25 ),提了个 PR 也无人响应
另外我们现在的 CodeStyle(Python 3.10,与上述的 3.12 问题无关)流水线经常在 build cmake-lint 时候挂(近一两个月出现的),最近频率越来越高了(今天一天看到了三个,其中有一个是我的 PR,这就忍不了了)
比如 https://xly.bce.baidu.com/paddlepaddle/paddle/newipipe/detail/9540260/job/24455968
根据报错可以得知是直接 PEP 517 build 时候挂了,原来的 cmake-lint 离谱地在
setup_requires
里写了个"pytest-runner"
,setup 时候依赖这个也不知道是为啥……https://github.com/cmake-lint/cmake-lint/blob/5f6c59c5b3d6224542327db4e55289117d32c636/setup.py#L40-L42
所以直接 fork 了个到 PFCCLab( https://github.com/PFCCLab/cmake-lint-paddle ),重写安装相关的,现在 3.7-3.12 都是有 CI 监测的
当然,以后如果有更优秀的 fork 或者更优秀的 CMake 相关 Linter 可以考虑切换
PCard-66972