| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 00:08:34 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=289.81807,conversation_content-fragment;desc="conversation_content fragment";dur=917.206885,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=371.964544,nginx;desc="NGINX";dur=1.241753,glb;desc="GLB";dur=100.569732
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=4PxQBC%2FSoVy8nOvH%2F3UJsqvSBvbI5UN1zygK2ksqskBtAKQimAAW9n5Fs6zCdeGipDOQZSDDOVtn3pKxhH1FHr1V0XIecOezEEdjQhNPmhLJdmSp6n7NUCukLwLh%2Bv6%2Bcm1Io5Ndn8Kw2dxnbOTgVLJ9%2B%2FSeerIZ1%2B2rCNMi%2B6%2FJO0uXlZ85NmNvrO61tWdhfC0vTqK01vY7jHdlTNHxiA4zDZfE1BJejc%2BVQK0zKbB5H%2FSlCCM25Hnoe%2FGJ%2BkBm8tCwoJz6Ym8I2qhUzHbKPg%3D%3D--mO%2BsrB%2B86REsPOch--j%2B%2FQtBc5sVovWs8zLJhGvg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1144366754.1753402113; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 00:08:33 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 00:08:33 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: AE5A:2D5B28:313C3:4D9B9:6882CB01
Move Dygraph Indexing Parsing to Pybind by zoooo0820 · Pull Request #58643 · PaddlePaddle/Paddle · GitHub
zoooo0820
force-pushed
the
indexing_to_pybind
branch
from
November 14, 2023 10:57
zoooo0820
force-pushed
the
indexing_to_pybind
branch
from
November 17, 2023 07:55
zoooo0820
changed the title
[Just for Test] Indexing to pybind
Move Dygraph Indexing Parsing to Pybind
Nov 17, 2023
zoooo0820
force-pushed
the
indexing_to_pybind
branch
from
November 17, 2023 10:22
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Move Dygraph Indexing Parsing to Pybind #58643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jeff41404
merged 25 commits into
PaddlePaddle:develop
from
zoooo0820:indexing_to_pybind
Nov 22, 2023
Merged
Move Dygraph Indexing Parsing to Pybind #58643
jeff41404
merged 25 commits into
PaddlePaddle:develop
from
zoooo0820:indexing_to_pybind
Nov 22, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zoooo0820
force-pushed
the
indexing_to_pybind
branch
from
33bfca4 to
69667ba
Compare
…th from stack to unsqueeze
zoooo0820
force-pushed
the
indexing_to_pybind
branch
from
1b68a46 to
5978d2d
Compare
zoooo0820
changed the title
zoooo0820
force-pushed
the
indexing_to_pybind
branch
from
5978d2d to
3e239fd
Compare
wanghuancoder
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jeff41404
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
* start down to pybind * basic-getitem down * fix compile error; basic-getitem seems work fine * finish advanced-getitem, runs well but still has bug to fix * fix parsing bug; getitem seems ok * finish setitem, still has bug to fix * fix some bug in advanced setitem * fix CI error about bool-tensor indexing * fix advance-indexing ci error * remove transpose if there is no need * support single py_boolean in index * add assert densetensor to avoid error in auto-parallel mode * add fast path for case single int tensor in getitem * change set_value_dygraph_function to ad_func * change vector type and fix the set_value_grad ut * fix inplace version error in backward by assign * remove any-check in bool tensor to boost getitem * remove no-used python code, keep xpu code to fix; py-code add fast path from stack to unsqueeze * fix py_bool cuda error * fix cuda config error when gpu_memory_available after all-false bool-tensor indexing * fix ci in 0-size gather_nd indexing * add dist tensor check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
Performance optimization
PR changes
Others
Description
Pcard-66985
For now, although there there is already complete indexing (i.e.
__getitem__/__setitem__) functional support, almost all the indexing parsing parts are running in Python, which brings much performance overhead.In this PR, we move indexing parsing of dygraph from Python to Pybind, aiming to optimize the performance (For static mode, still in Python).
some other things in this pr:
x[tensor[1,2]]): by replace thestacktounsqueeze.transposein advanced getting.anycheck in bool-mask indexing, since the any kernel and gpu->cpu memcpy is quite slow.condin bool-mask indexing, since currently this conditional block cannot be parsed in PIRFor convenience of review, the old indexing-parsing code will be deleted later.