| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 21:45:41 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=307.592163,conversation_content-fragment;desc="conversation_content fragment";dur=1756.462159,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=471.041345,nginx;desc="NGINX";dur=0.699946,glb;desc="GLB";dur=100.635039
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=73IetNyuIOBxS%2B2kU7HRBfAdfDFgra%2FmNACpN1uu1ng7I7QcVp30aK5iOBBr1wvbIqsBiphLy%2FQNPfpcQLdyvb62FhLhgWgGKkGAiXIZK7dQREXx31ICQ9hv9HOtJHkgp3nB2BOaALhyA%2Bt7S3dFehDYxkk8y4ST1ELOOJXvLaDktqaNvkRtn9OSQmEnk2KI7yDZkbs3jlz8v5ACHsQ0o1SeF4RKnF7O7PZo3aIAGfZvVLg4EO4KxmUlhZ%2Bz0ExzZYXV0BiFX3NvG3cmt1quTA%3D%3D--9n87HMJJX%2FbrhU%2FM--KA%2Bj6P4Aa2UN5a7ce5uSUA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1571445402.1753307139; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:45:39 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:45:39 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A53A:B5FA6:10ECC81:1435FB8:68815803
Merge comm into develop by hitywt · Pull Request #57897 · PaddlePaddle/Paddle · GitHub
hitywt
force-pushed
the
merge_comm_into_develop
branch
from
October 9, 2023 08:32
hitywt
force-pushed
the
merge_comm_into_develop
branch
from
October 13, 2023 02:54
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Merge comm into develop #57897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Merge comm into develop #57897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
hitywt
force-pushed
the
merge_comm_into_develop
branch
from
4602d7c to
04aabd8
Compare
fix compile tinyfix
hitywt
force-pushed
the
merge_comm_into_develop
branch
from
0c0041e to
6fde730
Compare
|
|
||
| #if defined(PADDLE_WITH_RCCL) | ||
| #include "paddle/phi/backends/dynload/rccl.h" | ||
| #else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里应该判断一下#elif defined(PADDLE_WITH_NCCL)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里应该判断一下
#elif defined(PADDLE_WITH_NCCL)
好的，这是冲突之后出现的，已修复
| @@ -163,7 +166,7 @@ class ProcessGroup { | |||
| phi::DenseTensor* out_tensor UNUSED, | |||
| const phi::DenseTensor& in_tensor UNUSED, | |||
| const BroadcastOptions& opts UNUSED, | |||
| bool sync_op UNUSED) { | |||
| bool sync_op UNUSED UNUSED) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里为啥用了两次UNUSED?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里为啥用了两次UNUSED?
已修复
| @@ -294,7 +297,7 @@ class ProcessGroup { | |||
| const phi::DenseTensor& in_tensor UNUSED, | |||
| const BroadcastOptions& opts UNUSED, | |||
| bool sync_op UNUSED, | |||
| bool use_calc_stream UNUSED) { | |||
| bool use_calc_stream) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的UNUSED是不是还得加上？后面报错了"ProcessGroup does not support broadcast with sync_op and use_calc_stream flag."后面的Broadcast看着是支持sync_op参数的，需要把sync_op的UNUSED删除吗？
其他的通信函数的sync_op好像也有一样的问题
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的UNUSED是不是还得加上？后面报错了
"ProcessGroup does not support broadcast with sync_op and use_calc_stream flag."后面的Broadcast看着是支持sync_op参数的，需要把sync_op的UNUSED删除吗？其他的通信函数的
sync_op好像也有一样的问题
UNUSED是在基类上加的，实例找不到实现时才会报错。这几个UNUSED这是develop分支加的，后续确认一下
GhostScreaming
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LiYuRio
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ForFishes
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zhiqiu
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lanxianghit
approved these changes
Oct 23, 2023
raindrops2sea
approved these changes
Oct 23, 2023
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Oct 24, 2023
* fix merge conflicts fix compile tinyfix * fix * format code style * fix code style * fix PR-CI-APPROVAL problems * fix PR-CI-APPROVAL problems * fix PR-CI-Py3 * fix PR-CI-Codestyle-Check * fix PR-CI-Codestyle-Check * fix PR-CI-Kunlun-R200 * fix PR-CI-Codestyle-Check * update * fix ci-compile * fix PR-CI-Coverage * fix PR-CI-Coverage * fix code style * fix PR-CI-Kunlun-R200 * fix conflicts * fix PR-CI-Kunlun-R200 * fix PR-CI-Py3 * fix PR-CI-Static-Check * update trace func * fix code style * update * fix compile * fix compile * cherry pick (PaddlePaddle#57260) * tiny update * tiny fix
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 26, 2023
* fix merge conflicts fix compile tinyfix * fix * format code style * fix code style * fix PR-CI-APPROVAL problems * fix PR-CI-APPROVAL problems * fix PR-CI-Py3 * fix PR-CI-Codestyle-Check * fix PR-CI-Codestyle-Check * fix PR-CI-Kunlun-R200 * fix PR-CI-Codestyle-Check * update * fix ci-compile * fix PR-CI-Coverage * fix PR-CI-Coverage * fix code style * fix PR-CI-Kunlun-R200 * fix conflicts * fix PR-CI-Kunlun-R200 * fix PR-CI-Py3 * fix PR-CI-Static-Check * update trace func * fix code style * update * fix compile * fix compile * cherry pick (PaddlePaddle#57260) * tiny update * tiny fix
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* fix merge conflicts fix compile tinyfix * fix * format code style * fix code style * fix PR-CI-APPROVAL problems * fix PR-CI-APPROVAL problems * fix PR-CI-Py3 * fix PR-CI-Codestyle-Check * fix PR-CI-Codestyle-Check * fix PR-CI-Kunlun-R200 * fix PR-CI-Codestyle-Check * update * fix ci-compile * fix PR-CI-Coverage * fix PR-CI-Coverage * fix code style * fix PR-CI-Kunlun-R200 * fix conflicts * fix PR-CI-Kunlun-R200 * fix PR-CI-Py3 * fix PR-CI-Static-Check * update trace func * fix code style * update * fix compile * fix compile * cherry pick (PaddlePaddle#57260) * tiny update * tiny fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
Others
PR changes
Others
Description
Pcard-70448
merge distributed communication related functions into develop